|
From: Florian K. <br...@ac...> - 2013-01-06 14:48:22
|
On 01/04/2013 06:21 AM, Julian Seward wrote: > > One change I am looking at is changing the guard type of Mux0X > from I8 to I1. This makes it consistent with I1 guard types for > Dirty helpers and for Exits. Seconded. > Changing the order of the second and third args in Mux0X, so it > matches the familiar C ?-: syntax, and possibly renaming it, > would be a nice thing, but does not change the generated code. > If anyone wants to volunteer to do that (and verify the change is > correct :) please speak up. Yes this would be good to do. I never understood why this IROp was defined this way and I made a few mistakes using it at the time. The change is obviously mechanical. But I would not know how to verify it other than having somebody else proof-read the patch. Passing regtest is too weak a criterion... I'm willing to make the change if you and/or other port maintainers are willing to double-check. Florian |