|
From: Petar J. <mip...@gm...> - 2012-12-03 00:00:26
|
Hi Bart, thanks for noticing this, it was incorrect. The change should be this (I believe): "prereq: ../../../tests/os_test linux 2.6.33 && ! ../../../tests/arch_test mips32" I'd better avoid committing stuff when I am sleep deprived. The commit message(s) would also have less typos. Petar On Sun, Dec 2, 2012 at 11:32 AM, Bart Van Assche <bva...@ac...> wrote: > On 12/02/12 04:38, sv...@va... wrote: >> >> petarj 2012-12-02 03:37:36 +0000 (Sun, 02 Dec 2012) >> >> New Revision: 13145 >> >> Log: >> Skip memcheck's getregset for MIPS. >> >> Skip the getregset test for MIPS since we still does not have >> TRACEHOOK >> support in MIPS kernel for it, and that is needed to support >> PTRACE_GETREGSET. >> >> Modified files: >> trunk/memcheck/tests/linux/getregset.vgtest >> >> >> Modified: trunk/memcheck/tests/linux/getregset.vgtest (+1 -1) >> =================================================================== >> --- trunk/memcheck/tests/linux/getregset.vgtest 2012-11-28 18:12:57 +00:00 >> (rev 13144) >> +++ trunk/memcheck/tests/linux/getregset.vgtest 2012-12-02 03:37:36 +00:00 >> (rev 13145) >> @@ -1,4 +1,4 @@ >> prog: getregset >> vgopts: -q >> -prereq: ../../../tests/os_test linux 2.6.33 >> +prereq: ../../../tests/os_test linux 2.6.33 && test >> `../../../tests/arch_test mips32` > > > Hello Petar, > > The arch_test program does not print any output as far as I know. So the > expression added in r13145 will invoke test without any arguments > independent of the platform it is invoked on. Are you sure that's what you > want ? Maybe this is what you were looking for ? > >> +prereq: ../../../tests/os_test linux 2.6.33 && ../../../tests/arch_test >> mips32 > > Bart. > |