|
From: <sv...@va...> - 2012-10-20 19:52:21
|
florian 2012-10-20 20:52:14 +0100 (Sat, 20 Oct 2012)
New Revision: 13064
Log:
Add a FIXME
Modified files:
trunk/coregrind/m_options.c
Modified: trunk/coregrind/m_options.c (+2 -0)
===================================================================
--- trunk/coregrind/m_options.c 2012-10-20 20:34:13 +01:00 (rev 13063)
+++ trunk/coregrind/m_options.c 2012-10-20 20:52:14 +01:00 (rev 13064)
@@ -211,6 +211,8 @@
} else if ('}' == format[i]) {
// Temporarily replace the '}' with NUL to extract var
// name.
+ // FIXME: this is not safe as FORMAT is sometimes a
+ // string literal which may reside in read-only memory
format[i] = 0;
qual = VG_(getenv)(qualname);
if (NULL == qual) {
|