Re: [Valgrind-developers] cache reorg fixup for x86/amd64

[Florian K. <br...@ac...>]

Hi Josef,

On 10/15/2012 04:10 PM, Josef Weidendorfer wrote:
>>
>> Two new functions have been added:
>> - cache_info_is_sensible: to check the autodetected cache info for
>>    feasibility
> 
> So if an autodetected cache info is not feasible, this is regarded as
> a bug?

This is more of a safe-guard to make sure the auto-detect code does
not stick something into VexCacheInfo that is bogus (for whatever
reason). valgrind execution will continue as usual. Except that
cachegrind won't find any caches.
Actually, that is not quite true yet. I just realise that I forgot to
empty out the VexCacheInfo stuff in case something infeasible was found.
Consider that done.

>> Cache detection itself does not issue any warnings anymore. The reason
>> is that cache detection happens all the time now
> 
> Isn't it just done when VG_(machine_get_cache_info) is called?

Yes, but VG_(machine_get_cache_info)  is called unconditionally from
VG_(machine_get_hwcaps) which itself is called all the time.

   Florian