|
From: Patrick J. L. <lop...@gm...> - 2012-08-23 17:54:10
|
On Thu, Aug 23, 2012 at 9:55 AM, Julian Seward <js...@ac...> wrote: > > There might be one complication though. If this works out, we will have > a situation where helpers can return V128/V256 values, so that 128/256 bit > shadow loads can be done in a single unit and hence we can do the partial- > loads-ok game, which IIUC is the motivation for all this. However, it does > mean Memcheck will then have an asymmetry w.r.t. processing shadow stores, > in the sense that they will still be chopped up into 64-bit pieces. So it > would ideally be nice to have a solution where we can also pass V128 and V256 > as arguments. Is that doable also using the platform dependent ABIs? IIUC > it's just more of the same game of passing the args on the stack, right? Doable, yes. But it does require implementation for every platform. Other than aesthetics, is there a technical reason for wanting this? (For example, do you think the performance would be improved for 128-bit stores?) It just seems like a bunch of work, both implementation and maintenance, if it is not something we technically need. Also, do you want my initial implementation to include V256 -- which, as far as I can tell, does not yet exist as a typedef -- or is V128 enough? - Pat |