[Valgrind-developers] Fix for floating point condition codes

[Christian B. <bor...@de...>]

Florian,

are you ok with this fix?

Index: VEX/priv/host_s390_isel.c
===================================================================
--- VEX/priv/host_s390_isel.c	(revision 2463)
+++ VEX/priv/host_s390_isel.c	(working copy)
@@ -2297,11 +2297,12 @@
          goto not_special;
       }
 
+      /* We can only handle Ity_I64, but the CC_DEPS field can have floats */
+      if (tyd != Ity_I64)
+         goto not_special;
+
       /* OK. Necessary conditions are satisfied. */
 
-      /* Get the old value and update it */
-      vassert(tyd == Ity_I64);
-
       old_value = env->old_value[guest_reg];
       new_value = stmt->Ist.Put.data->Iex.Const.con->Ico.U64;
       env->old_value[guest_reg] = new_value;


Christian