|
From: Sunny D. <int...@ya...> - 2012-06-01 14:10:39
|
> VALGRIND_NON_SIMD_CALLx(do_the_real_thing_on_the_real_cpu_function, > args ...); The max version of this macro allows 3 args. The vmware backdoor needs 4 args. Is it possible to extend this to 4,5,6 args easily? -Stay Sunny! --- On Wed, 5/30/12, Philippe Waroquiers <phi...@sk...> wrote: > From: Philippe Waroquiers <phi...@sk...> > Subject: Re: [Valgrind-developers] vmware backdoor patch > To: "Sunny Das" <int...@ya...> > Cc: "val...@li..." <val...@li...> > Date: Wednesday, May 30, 2012, 11:30 AM > On Wed, 2012-05-30 at 08:09 -0700, > Sunny Das wrote: > > The patch still seems to apply (after some path/file > renaming) but it does not build. That answers my original > question. But it raises a new one: > > > > Is anyone planning on fixing and merging that patch > in? > I have 0+epsilon intention to work on this patch, > the epsilon is to cover the unlikely case the vmware would > donate > 1_000_000 (1 million) dollars to support Valgrind > development :). > > (the patch is many lines, only to support vmware specific > things, > not clear how to test thist, etc). > So, does not look very attractive to me. > > > Why not rather do that at "user level" ? > (i.e. in the vmware code or libraries, do something like: > > if (RUNNING_ON_VALGRIND) > > VALGRIND_NON_SIMD_CALLx(do_the_real_thing_on_the_real_cpu_function, > args ...); > else > > do_the_real_thing_on_the_real_cpu_function (args); > > Looks to me this should have the effect desired, without > introducing > hundreds of vmware backdoor thingies in Valgrind. > > Philippe > > > |