|
From: Julian S. <js...@ac...> - 2012-02-23 09:25:24
|
> If the below is ok, I will prepare 3 (cleaned up) patches: > 1. a patch with the change below > 2. the patch to have the inner ignoring the vgpreload > of the outer (conditionalised on ENABLE_INNER) > 3. an helgrind annotation patch (conditionalised on ENABLE_INNER) Ok for 2 and 3, but please please add the description from your previous email as a big comment in 2, else nobody will understand the rationale. For 1 we maybe should clean up the unwinders so that they are allowed to travel inside the segment found by VG_(am_find_nsegment) and nowhere else. This would maybe clean up some ad hoc checks. Problem is VG_(am_find_nsegment) is expensive and Helgrind can ask for an unwind very very often (100K+ times/sec) so I would like to see if there is a way we can cache its results on a per thread basis, somehow (since they will change only rarely). J |