Menu
▾
▴
[Valgrind-developers] valgrind: r12380 - trunk/coregrind/m_syswrap
|
From: <sv...@va...> - 2012-02-10 16:49:41
|
Author: tom
Date: 2012-02-10 16:45:01 +0000 (Fri, 10 Feb 2012)
New Revision: 12380
Log:
Only mark data which has actually been filled in by recvmsg as defined.
Modified:
trunk/coregrind/m_syswrap/priv_syswrap-generic.h
trunk/coregrind/m_syswrap/syswrap-amd64-linux.c
trunk/coregrind/m_syswrap/syswrap-arm-linux.c
trunk/coregrind/m_syswrap/syswrap-darwin.c
trunk/coregrind/m_syswrap/syswrap-generic.c
trunk/coregrind/m_syswrap/syswrap-linux.c
trunk/coregrind/m_syswrap/syswrap-ppc32-linux.c
trunk/coregrind/m_syswrap/syswrap-ppc64-linux.c
trunk/coregrind/m_syswrap/syswrap-s390x-linux.c
trunk/coregrind/m_syswrap/syswrap-x86-linux.c
Modified: trunk/coregrind/m_syswrap/priv_syswrap-generic.h
===================================================================
--- trunk/coregrind/m_syswrap/priv_syswrap-generic.h 2012-02-10 11:54:16 UTC (rev 12379)
+++ trunk/coregrind/m_syswrap/priv_syswrap-generic.h 2012-02-10 16:45:01 UTC (rev 12380)
@@ -237,7 +237,7 @@
extern void ML_(generic_POST_sys_getpeername) ( TId, SR, UW, UW, UW );
extern void ML_(generic_PRE_sys_sendmsg) ( TId, Char *, struct vki_msghdr * );
extern void ML_(generic_PRE_sys_recvmsg) ( TId, Char *, struct vki_msghdr * );
-extern void ML_(generic_POST_sys_recvmsg) ( TId, Char *, struct vki_msghdr * );
+extern void ML_(generic_POST_sys_recvmsg) ( TId, Char *, struct vki_msghdr *, UInt );
extern void ML_(generic_PRE_sys_semop) ( TId, UW, UW, UW );
extern void ML_(generic_PRE_sys_semtimedop) ( TId, UW, UW, UW, UW );
Modified: trunk/coregrind/m_syswrap/syswrap-amd64-linux.c
===================================================================
--- trunk/coregrind/m_syswrap/syswrap-amd64-linux.c 2012-02-10 11:54:16 UTC (rev 12379)
+++ trunk/coregrind/m_syswrap/syswrap-amd64-linux.c 2012-02-10 16:45:01 UTC (rev 12380)
@@ -759,7 +759,7 @@
}
POST(sys_recvmsg)
{
- ML_(generic_POST_sys_recvmsg)(tid, "msg", (struct vki_msghdr *)ARG2);
+ ML_(generic_POST_sys_recvmsg)(tid, "msg", (struct vki_msghdr *)ARG2, RES);
}
PRE(sys_shutdown)
Modified: trunk/coregrind/m_syswrap/syswrap-arm-linux.c
===================================================================
--- trunk/coregrind/m_syswrap/syswrap-arm-linux.c 2012-02-10 11:54:16 UTC (rev 12379)
+++ trunk/coregrind/m_syswrap/syswrap-arm-linux.c 2012-02-10 16:45:01 UTC (rev 12380)
@@ -587,7 +587,7 @@
break;
case VKI_SYS_RECVMSG:
- ML_(generic_POST_sys_recvmsg)( tid, "msg", (struct vki_msghdr *)ARG2_1 );
+ ML_(generic_POST_sys_recvmsg)( tid, "msg", (struct vki_msghdr *)ARG2_1, RES );
break;
default:
@@ -711,7 +711,7 @@
}
POST(sys_recvmsg)
{
- ML_(generic_POST_sys_recvmsg)(tid, "msg", (struct vki_msghdr *)ARG2);
+ ML_(generic_POST_sys_recvmsg)(tid, "msg", (struct vki_msghdr *)ARG2, RES);
}
//XXX: Semaphore code ripped from AMD64.
Modified: trunk/coregrind/m_syswrap/syswrap-darwin.c
===================================================================
--- trunk/coregrind/m_syswrap/syswrap-darwin.c 2012-02-10 11:54:16 UTC (rev 12379)
+++ trunk/coregrind/m_syswrap/syswrap-darwin.c 2012-02-10 16:45:01 UTC (rev 12380)
@@ -3121,7 +3121,7 @@
POST(recvmsg)
{
- ML_(generic_POST_sys_recvmsg)(tid, "msg", (struct vki_msghdr *)ARG2);
+ ML_(generic_POST_sys_recvmsg)(tid, "msg", (struct vki_msghdr *)ARG2, RES);
}
Modified: trunk/coregrind/m_syswrap/syswrap-generic.c
===================================================================
--- trunk/coregrind/m_syswrap/syswrap-generic.c 2012-02-10 11:54:16 UTC (rev 12379)
+++ trunk/coregrind/m_syswrap/syswrap-generic.c 2012-02-10 16:45:01 UTC (rev 12380)
@@ -846,7 +846,8 @@
void msghdr_foreachfield (
ThreadId tid,
Char *name,
- struct vki_msghdr *msg,
+ struct vki_msghdr *msg,
+ UInt length,
void (*foreach_func)( ThreadId, Bool, Char *, Addr, SizeT )
)
{
@@ -882,11 +883,12 @@
foreach_func ( tid, True, fieldName,
(Addr)iov, msg->msg_iovlen * sizeof( struct vki_iovec ) );
-
for ( i = 0; i < msg->msg_iovlen; ++i, ++iov ) {
+ UInt iov_len = iov->iov_len <= length ? iov->iov_len : length;
VG_(sprintf) ( fieldName, "(%s.msg_iov[%u])", name, i );
foreach_func ( tid, False, fieldName,
- (Addr)iov->iov_base, iov->iov_len );
+ (Addr)iov->iov_base, iov_len );
+ length = length - iov_len;
}
}
@@ -1507,7 +1509,7 @@
void
ML_(generic_PRE_sys_sendmsg) ( ThreadId tid, Char *name, struct vki_msghdr *msg )
{
- msghdr_foreachfield ( tid, name, msg, pre_mem_read_sendmsg );
+ msghdr_foreachfield ( tid, name, msg, ~0, pre_mem_read_sendmsg );
}
/* ------ */
@@ -1515,13 +1517,13 @@
void
ML_(generic_PRE_sys_recvmsg) ( ThreadId tid, Char *name, struct vki_msghdr *msg )
{
- msghdr_foreachfield ( tid, name, msg, pre_mem_write_recvmsg );
+ msghdr_foreachfield ( tid, name, msg, ~0, pre_mem_write_recvmsg );
}
void
-ML_(generic_POST_sys_recvmsg) ( ThreadId tid, Char *name, struct vki_msghdr *msg )
+ML_(generic_POST_sys_recvmsg) ( ThreadId tid, Char *name, struct vki_msghdr *msg, UInt length )
{
- msghdr_foreachfield( tid, name, msg, post_mem_write_recvmsg );
+ msghdr_foreachfield( tid, name, msg, length, post_mem_write_recvmsg );
check_cmsg_for_fds( tid, msg );
}
Modified: trunk/coregrind/m_syswrap/syswrap-linux.c
===================================================================
--- trunk/coregrind/m_syswrap/syswrap-linux.c 2012-02-10 11:54:16 UTC (rev 12379)
+++ trunk/coregrind/m_syswrap/syswrap-linux.c 2012-02-10 16:45:01 UTC (rev 12380)
@@ -3598,7 +3598,7 @@
UInt i;
for (i = 0; i < RES; i++) {
VG_(sprintf)(name, "mmsg[%u].msg_hdr", i);
- ML_(generic_POST_sys_recvmsg)(tid, name, &mmsg[i].msg_hdr);
+ ML_(generic_POST_sys_recvmsg)(tid, name, &mmsg[i].msg_hdr, mmsg[i].msg_len);
POST_MEM_WRITE( (Addr)&mmsg[i].msg_len, sizeof(mmsg[i].msg_len) );
}
}
Modified: trunk/coregrind/m_syswrap/syswrap-ppc32-linux.c
===================================================================
--- trunk/coregrind/m_syswrap/syswrap-ppc32-linux.c 2012-02-10 11:54:16 UTC (rev 12379)
+++ trunk/coregrind/m_syswrap/syswrap-ppc32-linux.c 2012-02-10 16:45:01 UTC (rev 12380)
@@ -672,7 +672,7 @@
break;
case VKI_SYS_RECVMSG:
- ML_(generic_POST_sys_recvmsg)( tid, "msg", (struct vki_msghdr *)ARG2_1 );
+ ML_(generic_POST_sys_recvmsg)( tid, "msg", (struct vki_msghdr *)ARG2_1, RES );
break;
default:
Modified: trunk/coregrind/m_syswrap/syswrap-ppc64-linux.c
===================================================================
--- trunk/coregrind/m_syswrap/syswrap-ppc64-linux.c 2012-02-10 11:54:16 UTC (rev 12379)
+++ trunk/coregrind/m_syswrap/syswrap-ppc64-linux.c 2012-02-10 16:45:01 UTC (rev 12380)
@@ -700,7 +700,7 @@
break;
case VKI_SYS_RECVMSG:
- ML_(generic_POST_sys_recvmsg)( tid, "msg", (struct vki_msghdr *)ARG2_1 );
+ ML_(generic_POST_sys_recvmsg)( tid, "msg", (struct vki_msghdr *)ARG2_1, RES );
break;
default:
Modified: trunk/coregrind/m_syswrap/syswrap-s390x-linux.c
===================================================================
--- trunk/coregrind/m_syswrap/syswrap-s390x-linux.c 2012-02-10 11:54:16 UTC (rev 12379)
+++ trunk/coregrind/m_syswrap/syswrap-s390x-linux.c 2012-02-10 16:45:01 UTC (rev 12380)
@@ -740,7 +740,7 @@
break;
case VKI_SYS_RECVMSG:
- ML_(generic_POST_sys_recvmsg)( tid, "msg", (struct vki_msghdr *)ARG2_1 );
+ ML_(generic_POST_sys_recvmsg)( tid, "msg", (struct vki_msghdr *)ARG2_1, RES );
break;
default:
Modified: trunk/coregrind/m_syswrap/syswrap-x86-linux.c
===================================================================
--- trunk/coregrind/m_syswrap/syswrap-x86-linux.c 2012-02-10 11:54:16 UTC (rev 12379)
+++ trunk/coregrind/m_syswrap/syswrap-x86-linux.c 2012-02-10 16:45:01 UTC (rev 12380)
@@ -1693,8 +1693,8 @@
break;
case VKI_SYS_RECVMSG:
- ML_(generic_POST_sys_recvmsg)( tid, "msg", (struct vki_msghdr *)ARG2_1 );
- break;
+ ML_(generic_POST_sys_recvmsg)( tid, "msg", (struct vki_msghdr *)ARG2_1, RES );
+ break;
default:
VG_(message)(Vg_DebugMsg,"FATAL: unhandled socketcall 0x%lx\n",ARG1);
|
