Menu
▾
▴
Re: [Valgrind-developers] valgrind: r12359 - in trunk: . memcheck/tests
|
From: Bart V. A. <bva...@ac...> - 2012-02-05 17:29:05
|
On Sun, Feb 5, 2012 at 5:24 PM, Florian Krohm <br...@ac...> wrote:
> But we already check at the very beginning that the expr tags are the same:
>
> static Bool sameIRExprs ( IRExpr** env, IRExpr* e1, IRExpr* e2 )
> {
> if (e1->tag != e2->tag) return False; // <----<<
>
> switch (e1->tag) {
> case Iex_RdTmp:
> if (e1->Iex.RdTmp.tmp == e2->Iex.RdTmp.tmp) return True;
Yes, I just noticed that myself too ...
The good news is if that if I run the Valgrind regression tests on an
x86_64 system with your patch applied that not only
memcheck/tests/bug287260 passes but also that the output of all other
regression tests is unaffected. The output of "make regtest" is the
same as what I got before on openSUSE 12.1:
== 606 tests, 2 stderr failures, 0 stdout failures, 0 stderrB
failures, 0 stdoutB failures, 0 post failures ==
memcheck/tests/origin5-bz2 (stderr)
memcheck/tests/overlap (stderr)
Bart.
|
