|
From: Florian K. <br...@ac...> - 2011-10-08 17:10:27
|
On 10/07/2011 09:46 AM, Julian Seward wrote: > > It's great to see the regtests getting fixed up. > > Relatedly .. if you add/remove/rename svn-tracked files > (in this case, the various expected-output files), please be sure > to update EXTRA_DIST in the associated Makefile.am. If that > doesn't happen then either > > (a) "make dist" (building the tarball) fails, or > (b) make dist works, but running regression tests from a > tarball fails, because files are missing, or > (c) running regression tests from a tarball falsely causes some tests > on some platforms to fail when the same from-svn-tree would succeed, > because the necessary special-case .exp files are missing. > > (c) is particularly scary, because it's invisible most of the time. > > I just tried running 'make dist', and it fails with > make[2]: *** No rule to make target `badjump.stderr.exp-s390x', needed by > `distdir'. Stop. > > Looking back over the commits of the past few days, I see the following > which added/removed/renamed files, but have no Makefile.am changes: > > 12107 12103 12098 12097 12092 12091 12079 12077 > I plead guilty. Sorry for that. I keep forgetting about make dist. I'll try to be more careful. Florian |