Re: [Valgrind-developers] Compile error related to futex.h

[Bart V. A. <bva...@ac...>]

On Thu, Sep 15, 2011 at 5:10 AM, Florian Krohm <br...@ac...> wrote:
>
> a colleague of mine at the IBM labs (who runs the BEAM checker every
> once in a while) noticed that he can no longer compile valgrind.
> The error occurs when compiling drd_pthread_intercepts.c:
>
> In file included from drd_pthread_intercepts.c:61:
> /usr/include/linux/futex.h:96: error: expected ‘)’ before ‘*’ token
> /usr/include/linux/futex.h:100: error: expected ‘)’ before ‘*’ token
>
> I'm including his futex.h. It's quite clear that the error is related to
> the type u32 not being defined.

As you probably know that's a bug in the futex.h header. Does the
patch below help ?

Bart.

Index: drd/drd_pthread_intercepts.c
===================================================================
--- drd/drd_pthread_intercepts.c        (revision 12034)
+++ drd/drd_pthread_intercepts.c        (working copy)
@@ -58,6 +58,7 @@
 #include <unistd.h>         /* confstr() */
 #ifdef __linux__
 #include <asm/unistd.h>     /* __NR_futex */
+#include <linux/types.h>
 #include <linux/futex.h>    /* FUTEX_WAIT */
 #ifndef FUTEX_PRIVATE_FLAG
 #define FUTEX_PRIVATE_FLAG 0