Re: [Valgrind-developers] valgrind: r12012 - trunk/nightly/bin

[Bart V. A. <bva...@ac...>]

On Tue, Sep 6, 2011 at 7:17 PM, <sv...@va...> wrote:
> Modified: trunk/nightly/bin/nightly
> ===================================================================
> --- trunk/nightly/bin/nightly   2011-09-06 11:26:31 UTC (rev 12011)
> +++ trunk/nightly/bin/nightly   2011-09-06 17:17:41 UTC (rev 12012)
> @@ -11,7 +11,11 @@
>
>  # Returns the revision number of the source files with date $1.
>  get_svn_revision() {
> -  svn info -r "{$1}" "${valgrind_svn_repo}" | sed -n 's/^Revision: //p'
> +  (cd $DIR; rm -rf infodir;
> +   svn co -r "{$1}" "${valgrind_svn_repo}/nightly" infodir > /dev/null;
> +   revno=`svn info infodir | sed -n 's/^Revision: //p'`;
> +   rm -rf infodir;
> +   echo $revno)
>  }
>
>  runcmd () {

Hello Florian,

Have you considered to run the "svn co -r ..." alternative only if
"svn info -r ..." fails ? The above change seems somewhat invasive to
me - it changes the number of Valgrind tree checkouts from two to four
per nightly build.

Bart.