|
From: Konstantin S. <kon...@gm...> - 2011-04-20 18:13:17
|
I would implement an option to enable/disable addresses (--show-pc=no/yes). As for the default value -- I don't know. (TSan's default is no, but I myself suffer from it periodically). --kcc On Wed, Apr 20, 2011 at 6:21 PM, Alexander Potapenko <gl...@go...>wrote: > Spending much time on debugging the reports from the TSan tool I would > suggest not to remove the addresses. > You don't need those while you have the debug info, but if you don't, > you'll have to re-run the program with the --show-pc=yes option in > order to debug a newly appeared report (the old and known ones are > already suppressed, aren't they?). > Maybe just move the address to the end of line? Like this: > > Invalid write of size 1 > at ddd (errs1.c:7), pc=0x400544 > by ccc (errs1.c:8), pc=0x400550 > by bbb (errs1.c:9), pc=0x40055B > > > Alex > > On Wed, Apr 20, 2011 at 3:17 PM, Tom Hughes <to...@co...> wrote: > > On 20/04/11 11:12, Julian Seward wrote: > > > >> * change of backtrace format? For years we've had code addresses > >> in backtraces. They use up valuable screen space, but 99% of the > >> time are completely useless. Should we omit them by default, > >> as does the TSan tool? > >> eg > >> Invalid write of size 1 > >> at 0x400544: ddd (errs1.c:7) > >> by 0x400550: ccc (errs1.c:8) > >> by 0x40055B: bbb (errs1.c:9) > >> by 0x400566: aaa (errs1.c:10) > >> by 0x4005AE: main (errs1.c:17) > >> vs > >> Invalid write of size 1 > >> #0 ddd (errs1.c:7) > >> #1 ccc (errs1.c:8) > >> #2 bbb (errs1.c:9) > >> #3 aaa (errs1.c:10) > >> #4 main (errs1.c:17) > > > > I agree that the address is generally not useful, except I would say in > > the case of the first frame, where it gives you the address of the exact > > instruction which triggered the report. > > > > Maybe we could capture that on the first line, something like: > > > > Invalid write of size 1 at 0x400544 > > > > and then drop the addresses from the stack trace. > > > > Tom > > > > -- > > Tom Hughes (to...@co...) > > http://compton.nu/ > > > > > ------------------------------------------------------------------------------ > > Benefiting from Server Virtualization: Beyond Initial Workload > > Consolidation -- Increasing the use of server virtualization is a top > > priority.Virtualization can reduce costs, simplify management, and > improve > > application availability and disaster protection. Learn more about > boosting > > the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev > > _______________________________________________ > > Valgrind-developers mailing list > > Val...@li... > > https://lists.sourceforge.net/lists/listinfo/valgrind-developers > > > > > > -- > Alexander Potapenko > Software Engineer > Google Moscow > > > ------------------------------------------------------------------------------ > Benefiting from Server Virtualization: Beyond Initial Workload > Consolidation -- Increasing the use of server virtualization is a top > priority.Virtualization can reduce costs, simplify management, and improve > application availability and disaster protection. Learn more about boosting > the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev > _______________________________________________ > Valgrind-developers mailing list > Val...@li... > https://lists.sourceforge.net/lists/listinfo/valgrind-developers > |