|
From: John R. <jr...@bi...> - 2011-04-20 15:00:45
|
On 04/20/2011 07:21 AM, Alexander Potapenko wrote: > Spending much time on debugging the reports from the TSan tool I would > suggest not to remove the addresses. > You don't need those while you have the debug info, In practice, line numbers are not precise enough. The same line often maps to many different and non-consecutive PCs, and consecutive PCs often map to non-consecutive lines. Debugging often involves mental "backward execution". Not having the correct PC as a starting point makes it much harder than necessary. but if you don't, > you'll have to re-run the program with the --show-pc=yes option in > order to debug a newly appeared report (the old and known ones are > already suppressed, aren't they?). > Maybe just move the address to the end of line? Like this: > > Invalid write of size 1 > at ddd (errs1.c:7), pc=0x400544 > by ccc (errs1.c:8), pc=0x400550 > by bbb (errs1.c:9), pc=0x40055B Fields that have an almost-fixed width should have a preference for the fixed side [the left side] of a line, so that columnar organization tends to be evident and usable. The width of the PC is nearly fixed, while the width of the source designator is much more variable. The above example, with only one filename, and with line numbers having the same floor(log10(__LINE__)), is not typical. -- |