|
From: Bart V. A. <bva...@ac...> - 2010-09-08 16:43:32
|
On Wed, Sep 8, 2010 at 12:39 PM, Julian Seward <js...@ac...> wrote: > > Umm, I must say, I don't think this is a good solution. Yes, it means > that this specific call of VG_TRACK( die_mem_stack, ... ) does not send > a zero length to drd_stop_using_mem. But there are other places where > die_mem_stack and related functions (new_mem_*) are sent to tools, and > we would have to audit all of those call sites too. The interface never > promised that such functions would not be called with len == 0. > > It would I think be better for all the places that such a notification > could be sent to (eg, drd_stop_using_mem) to be robust to a len == 0 > value. The reason DRD did complain about empty address ranges was exactly to catch invocations of tracking functions by the core with empty address ranges. Since all code in DRD that did complain about empty address ranges works fine with empty address ranges, I have replaced the "tl_assert(a1 < a2)" statements by "tl_assert(a1 <= a2)" in r11346. Bart. |