Re: [Valgrind-developers] [PATCH - v2] Complete the IBM POWER6 support (Power ISA Version 2.05)

[Maynard J. <may...@us...>]

On 08/12/2010 3:44 AM, Julian Seward wrote:
>
> Maynard, thanks for the patch.
>
> Please could you open a bug report and attach the patches, including
> the test programs, to the bug report.  Patches sent to the mailing list
> are at (serious) risk of falling through the cracks and disappearing.
> Also, putting patches in the bug tracker gives a single URL at which
> we can point anybody interested.

Julian,
Thanks for the reply.  I opened a bug report as you asked: 
https://bugs.kde.org/show_bug.cgi?id=247526.

-Maynard
>
> See http://www.valgrind.org/support/bug_reports.html for directions
> on filing bug reports.
>
> J
>
> On Wednesday, August 11, 2010, Maynard Johnson wrote:
>> On 08/11/2010 10:38 AM, Maynard Johnson wrote:
>>> On 08/10/2010 2:36 PM, Maynard Johnson wrote:
>>>> Bart Van Assche wrote:
>>>>> On Tue, Aug 10, 2010 at 5:59 PM, Maynard Johnson<may...@us...>
> wrote:
>>>>>> Bart Van Assche wrote:
>>>>>>> On Mon, Aug 9, 2010 at 11:59 PM, Maynard
> Johnson<may...@us...>wrote:
>>>>>>>> Currently, Valgrind has only partial support for new IBM POWER6
>>>>>>>> instructions (as defined in
>>>>>>>> http://www.power.org/resources/reading/PowerISA_V2.05.pdf). The
>>>>>>>> attached patch completes the 2.05 support.
>>>>>>>>
>>>>>>>> The results of running 'make regtest' on a POWER6 box are almost
>>>>>>>> identical before and after applying this patch -- about 50 failing
>>>>>>>> testcases. I have looked into many of those failing testcases and,
>>>>>>>> so far, have been able to cut the number of failures to less than
>>>>>>>> half that. I have a separate testsuite patch that I will submit
>>>>>>>> separately (upon request, or I'll wait until this patch is
>>>>>>>> accepted) that provides the improved testsuite results.
>>>>>>>>
>>>>>>>> Review comments are welcome.
>>>
>>> The attached "version 2" patch fixes the formatting issues that Bart
>>> pointed out, plus a couple other minor nits I found while scrubbing it.
>>> This patch was made against a snapshot of today's SVN repository. But as
>>> I mentioned earlier to Bart, applying the patch will result in an
>>> expected failure involving none/tests/ppc64/jm-insns.c, since this file
>>> is symbolically linked to none/tests/ppc32/jm-insns.c, which is patched
>>> earlier on during the patch application. Just hit "Enter" twice to
>>> ignore that failure, and the rest of the patch should apply cleanly.
>>
>> Another thing I should have mentioned . . . This patch contains some new
>> shell scripts which need to be changed to executable before attempting to
>> run the testsuite.  These new script files are:
>>      - memcheck/tests/ppc32/filter_stderr
>>      - memcheck/tests/ppc64/filter_stderr
>>      - none/tests/ppc32/check_vmx_cap
>>      - none/tests/ppc64/check_vmx_cap
>>
>> -Maynard
>>
>>> Thanks.
>>> -Maynard
>>>
>>>
>>>
>>> -------------------------------------------------------------------------
>>> ----- This SF.net email is sponsored by
>>>
>>> Make an app they can't live without
>>> Enter the BlackBerry Developer Challenge
>>> http://p.sf.net/sfu/RIM-dev2dev
>>>
>>>
>>>
>>> _______________________________________________
>>> Valgrind-developers mailing list
>>> Val...@li...
>>> https://lists.sourceforge.net/lists/listinfo/valgrind-developers
>>
>> ---------------------------------------------------------------------------
>> --- This SF.net email is sponsored by
>>
>> Make an app they can't live without
>> Enter the BlackBerry Developer Challenge
>> http://p.sf.net/sfu/RIM-dev2dev
>> _______________________________________________
>> Valgrind-developers mailing list
>> Val...@li...
>> https://lists.sourceforge.net/lists/listinfo/valgrind-developers
>