|
From: Maynard J. <may...@us...> - 2010-08-11 15:38:07
|
On 08/10/2010 2:36 PM, Maynard Johnson wrote: > Bart Van Assche wrote: >> On Tue, Aug 10, 2010 at 5:59 PM, Maynard Johnson<may...@us...> wrote: >>> >>> Bart Van Assche wrote: >>>> On Mon, Aug 9, 2010 at 11:59 PM, Maynard Johnson<may...@us...>wrote: >>>> >>>>> Currently, Valgrind has only partial support for new IBM POWER6 >>>>> instructions (as defined in >>>>> http://www.power.org/resources/reading/PowerISA_V2.05.pdf). The attached >>>>> patch completes the 2.05 support. >>>>> >>>>> The results of running 'make regtest' on a POWER6 box are almost identical >>>>> before and after applying this patch -- about 50 failing testcases. I have >>>>> looked into many of those failing testcases and, so far, have been able to >>>>> cut the number of failures to less than half that. I have a separate >>>>> testsuite patch that I will submit separately (upon request, or I'll wait >>>>> until this patch is accepted) that provides the improved testsuite results. >>>>> >>>>> Review comments are welcome. >>>>> The attached "version 2" patch fixes the formatting issues that Bart pointed out, plus a couple other minor nits I found while scrubbing it. This patch was made against a snapshot of today's SVN repository. But as I mentioned earlier to Bart, applying the patch will result in an expected failure involving none/tests/ppc64/jm-insns.c, since this file is symbolically linked to none/tests/ppc32/jm-insns.c, which is patched earlier on during the patch application. Just hit "Enter" twice to ignore that failure, and the rest of the patch should apply cleanly. Thanks. -Maynard |