|
From: Maynard J. <may...@us...> - 2010-08-10 19:37:19
|
Bart Van Assche wrote: > On Tue, Aug 10, 2010 at 5:59 PM, Maynard Johnson <may...@us...> wrote: >> >> Bart Van Assche wrote: >>> On Mon, Aug 9, 2010 at 11:59 PM, Maynard Johnson <may...@us...>wrote: >>> >>>> Currently, Valgrind has only partial support for new IBM POWER6 >>>> instructions (as defined in >>>> http://www.power.org/resources/reading/PowerISA_V2.05.pdf). The attached >>>> patch completes the 2.05 support. >>>> >>>> The results of running 'make regtest' on a POWER6 box are almost identical >>>> before and after applying this patch -- about 50 failing testcases. I have >>>> looked into many of those failing testcases and, so far, have been able to >>>> cut the number of failures to less than half that. I have a separate >>>> testsuite patch that I will submit separately (upon request, or I'll wait >>>> until this patch is accepted) that provides the improved testsuite results. >>>> >>>> Review comments are welcome. >>>> >>> >>> Which Valgrind version has the patch been developed against ? >>> >>> I have tried to apply the patch to the latest trunk version, but it doesn't >>> seem to apply cleanly: >>> >>> [ ... ] >>> patching file none/tests/ppc64/jm-insns.c >>> Reversed (or previously applied) patch detected! Assume -R? [n] >>> Apply anyway? [n] >>> Skipping patch. >>> 2 out of 2 hunks ignored -- saving rejects to file >>> none/tests/ppc64/jm-insns.c.rej >> >> The patch was made against an August 6 SVN snapshot. Sorry, I forgot to mention the rejection of the patch to none/tests/ppc64/jm-insns.c is actually expected. This happens because that file is a symbolic link to none/tests/ppc32/jm-insns.c, which is patched earlier. > > The only other comment I have on the patch is that the indentation > style of the VEX changes is different from the surrounding code: the > added code has been indented with tabs while the surrounding code is > not. hmmm . . . yeah, ugly. Let me re-swizzle and clean it up a bit. -Maynard > > Note: since the patch includes VEX changes, only Julian can apply it. > > Bart. |