|
From: Konstantin S. <kon...@gm...> - 2009-12-29 15:38:17
|
On Tue, Dec 29, 2009 at 6:19 PM, Bart Van Assche <bar...@gm...>wrote: > On Tue, Dec 29, 2009 at 11:53 AM, Konstantin Serebryany > <kon...@gm...> wrote: > > First question: > > Valgrind installation contains include files, which makes me think that > it is possible to build valgrind tools w/o having the valgrind sources. > > However, with the current version of valgrind, it does dot > work: include/valgrind/pub_tool_basics.h includes "config.h", which is not a > part of valgrind installation. > > Can that be fixed? > > The header file "config.h" is included because the configure script > figures out whether or not the selected compiler supports > __builtin_expect() (HAVE_BUILTIN_EXPECT). Since gcc supports > __builtin_expect() since at least gcc 3.0, and since we only support > gcc 3.2 and above, it's probably safe to remove the #ifdef > HAVE_BUILTIN_EXPECT and #include "config.h". > That sounds good! > > > Third question: > > Few of the valgrind public headers are not C++-able. > > Can that be fixed? > > Should be fixed through r10970 and r10971. By the way, r10970 builds > fine on Darwin and x86-64 but not on PPC. > Yep, works! Thanks! --kcc > > Bart. > |