|
From: Tom H. <to...@co...> - 2009-09-18 15:28:34
|
On 18/09/09 14:56, Robert Bragg wrote: > I've attached a patch for coregrind/m_syswrap/syswrap-linux.c that > describes enough of the drm ioctls that I can remove the memsets in > libdrm and run the applications I work on with Valgrind knowing what's > going on. In include/vki/vki-linux-drm.h I've tried to add all the > structures and ioctl definitions so it should be relatively straight > forward to add additional drm ioctls to syswrap-linux.c in an > incremental fashion. Please file a bug in bugzilla and attach your patch to that so it doesn't get forgotten about. > I'd love to get some feedback on this patch and to know if this is > something that could be accepted upstream? Well the only obvious thing is the new include file - there is no precedent for that as we have previously simple added all required structure definitions etc to vki-linux.h rather than creating new files. Beyond that it will be a case of somebody going through it and checking each call against the kernel source, which is a slow and horrible job for ioctls. Tom -- Tom Hughes (to...@co...) http://www.compton.nu/ |