|
From: Bart V. A. <bar...@gm...> - 2009-08-24 18:30:35
|
On Mon, Aug 24, 2009 at 12:19 AM, Nicholas Nethercote <n.n...@gm...> wrote: > > On Sun, Aug 23, 2009 at 9:11 PM, <sv...@va...> wrote: > > Author: bart > > Date: 2009-08-23 12:11:36 +0100 (Sun, 23 Aug 2009) > > New Revision: 10861 > > > > Log: > > Fixed a declaration: function attributes must be inserted after the return type instead of before, otherwise gcc 4.4 ignores the attribute declaration. > > Really? Is this described in the GCC docs anywhere? It's a very > disturbing change, I'm sure we have numerous functions where the > attribute comes first. The above comment is somewhat related to r10859. I had noticed that gcc 4.3.2 did rightfully complain about the statement on line 138 of coregrind/launcher-linux.c, but gcc 4.4.1 did not. So I started searching the Valgrind source code for other format attribute declarations, and noticed that other format attribute declarations were present at the end of the function declaration instead of the beginning. The above comment might have been a too quick conclusion however. Bart. |