|
From: Nicholas N. <n.n...@gm...> - 2009-08-23 22:23:01
|
On Mon, Aug 24, 2009 at 2:13 AM, Bart Van Assche<bar...@gm...> wrote: > > Earlier today I found out that the functions defined in the source file > coregrind/m_aspacemgr/aspacemgr-linux.c are not only used on Linux but that > some of the functions defined in this source file are also needed for the > Darwin build. This is misleading. It might be appropriate to refactor this > module such that operating-system neutral code is moved to a common file and > only operating-system specific code remains in the source file > aspacemgr-linux.c. It's like that because the two OSes share roughly 90% of the code, but the AIX version is quite different, so I couldn't see a clean way to break it up. The easiest thing would be to rename the file as aspacemgr-linux-darwin.c. Nick |