|
From: Ashley P. <as...@pi...> - 2009-08-23 08:49:08
|
On Sat, 2009-08-22 at 10:49 +1000, Nicholas Nethercote wrote: > Here's a summary of a proposal. > I haven't thought much about XML yet, but hopefully the stuff we > produce via XML matches the "==pid==" category pretty closely, and > "--pid--" and "++pid++" messages won't end up in XML. My thoughts about XML are that is should contain at least as much output as the non XML output, in fact being able to re-create the normal output from the XML output is a good test that it's complete. Currently there are some options which the XML ignores, or rather are assumed turned on IIRC and it prints the output for them even if it isn't requested (--leak-check=yes) springs to mind. I think this is probably a good thing although it's perhaps not always clear that it's doing it. I would say that if it's zero cost for valgrind to collect the data then it should be included in the xml and any higher level tool can be assumed to look at the command line and only display the requested output. If collecting data has cost, like --trace-origins then it shouldn't be collected unless requested. > Any thoughts? I think it'll help users, because if they don't > understand a message at least they'll know what it pertains to (eg. > their program vs. Valgrind itself). And debugging info is cleanly > segregated. And currently a lot of messages don't have a prefix, so > if the prefix is added at least it's clear that it comes from > Valgrind. Sounds like a good idea to me. If in the process of this it would be possible to enable both xml and normal output somehow then that would be appreciated as well. https://bugs.kde.org/show_bug.cgi?id=204842 Forcing a rename of VG_(printf)() to something else would help catch all the error paths which currently just report to the error log without any matching XML warnings, hopefully it would allow xml reporting of these errors as well. Ashley, -- Ashley Pittman, Bath, UK. Padb - A parallel job inspection tool for cluster computing http://padb.pittman.org.uk |