|
From: <sv...@va...> - 2009-08-05 05:05:29
|
Author: njn
Date: 2009-08-05 06:05:15 +0100 (Wed, 05 Aug 2009)
New Revision: 10714
Log:
Augment a comment.
Modified:
trunk/memcheck/mc_main.c
Modified: trunk/memcheck/mc_main.c
===================================================================
--- trunk/memcheck/mc_main.c 2009-08-05 04:57:44 UTC (rev 10713)
+++ trunk/memcheck/mc_main.c 2009-08-05 05:05:15 UTC (rev 10714)
@@ -5780,6 +5780,12 @@
// - Telying on the zeroed-ness of whole brk'd pages is pretty grotty... I
// doubt most programmers know the above information.
// So I'm not terribly unhappy with marking it as undefined. --njn.
+ //
+ // [More: I think most of what John said only applies to sbrk(). It seems
+ // that brk() always deals in whole pages. And since this event deals
+ // directly with brk(), not with sbrk(), perhaps it would be reasonable to
+ // just mark all memory it allocates as defined.]
+ //
VG_(track_new_mem_brk) ( make_mem_undefined_w_tid );
VG_(track_new_mem_mmap) ( mc_new_mem_mmap );
|