[Valgrind-developers] Removing statistics printing from -v

[Julian S. <js...@ac...>]

Hi,

As part of trying to fix
https://bugs.kde.org/show_bug.cgi?id=186790 properly, I made a
change which is long overdue: removing the printing of statistics
from "-v".  Up to now, -v has caused the printing of some
additional information which might be useful to the user, such as
error and suppression counts, details of the CPU, and
redirections happening.  But it also printed large amounts of
statistics, both for the core and the tool, which is mostly not
of interest to users, and is distracting.

The attached patch removes statistics printing from -v, and gives
it a new flag --stats=no|yes [no].  For most tools this
significantly tidies up the -v output, and means we can continue
to restrict it to output which is of interest to users.

I think this would be a good cleanup to have, but it changes the
flag behaviour a bit, so feedback would be good.  For all the
tools that report errors, the non "-v" output is unchanged, I
believe, except for one thing: DRD, Helgrind and Ptrcheck will
print the following extra line just before the final error
summary line:

==12025== For counts of detected errors, rerun with: -v

This patch also contains my proposed fix to #186790, including
some changes to the spacing and wording of the preamble preceding
Memcheck's leak check.  (Merely swapping around the order of the
leak check and tool finalisation makes the output look a bit
strange, hence the adjustments).

I'm sure this breaks all the regtests, because the filters
need to change a bit.  I haven't looked into that yet.

J