|
From: Bart V. A. <bar...@gm...> - 2009-07-01 19:48:31
|
On Wed, Jul 1, 2009 at 1:59 AM, Nicholas
Nethercote<n.n...@gm...> wrote:
> On Tue, Jun 30, 2009 at 5:47 PM, Bart Van
> Assche<bar...@gm...> wrote:
>>
>> Nightly build on georgia-tech-cellbuzz-native ( cellbuzz, ppc64, Fedora 7, native )
>> =================================================
>> == Difference between 24 hours ago and now ==
>> =================================================
>>
>> *** old.short Tue Jun 30 03:01:12 2009
>> --- new.short Tue Jun 30 03:47:06 2009
>> ***************
>> *** 8,10 ****
>>
>> ! == 419 tests, 36 stderr failures, 12 stdout failures, 0 post failures ==
>> memcheck/tests/deep_templates (stdout)
>> --- 8,10 ----
>>
>> ! == 420 tests, 40 stderr failures, 13 stdout failures, 0 post failures ==
>> memcheck/tests/deep_templates (stdout)
>> ***************
>> *** 21,22 ****
>> --- 21,23 ----
>> memcheck/tests/wrap8 (stderr)
>> + none/tests/empty-exe (stderr)
>> none/tests/linux/mremap (stderr)
>> ***************
>> *** 30,33 ****
>> --- 31,38 ----
>> none/tests/ppc64/round (stdout)
>> + none/tests/shell (stdout)
>> + none/tests/shell (stderr)
>> + none/tests/shell_valid1 (stderr)
>> none/tests/shell_valid2 (stderr)
>> none/tests/shell_valid3 (stderr)
>> + none/tests/shell_zerolength (stderr)
>> helgrind/tests/hg05_race2 (stderr)
>
> The shell failures could be due to r10387 and r10384. Any chance you
> could take a look at this? It looks like select_platform() in
> coregrind/launcher-linux.c might be returning NULL in cases it
> shouldn't. If you could do some printf debugging or GDB tracing that
> would be really helpful... thanks.
After having applied the patch below I get the following results:
$ perl tests/vg_regtest none
...
$ grep Assert none/tests/*diff*
none/tests/cmdline6.stderr.diff:+valgrind: launcher-linux.c:193:
select_platform: Assertion `platform' failed.
none/tests/empty-exe.stderr.diff:+valgrind: launcher-linux.c:131:
select_platform: Assertion `0' failed.
none/tests/shell_binaryfile.stderr.diff:+valgrind:
launcher-linux.c:193: select_platform: Assertion `platform' failed.
none/tests/shell_dir.stderr.diff:+valgrind: launcher-linux.c:131:
select_platform: Assertion `0' failed.
none/tests/shell_nonexec.stderr.diff:+valgrind: launcher-linux.c:193:
select_platform: Assertion `platform' failed.
none/tests/shell_valid2.stderr.diff:+valgrind: launcher-linux.c:193:
select_platform: Assertion `platform' failed.
none/tests/shell_zerolength.stderr.diff:+valgrind:
launcher-linux.c:131: select_platform: Assertion `0' failed.
none/tests/shell_zerolength.stderr.diff-dash:+valgrind:
launcher-linux.c:131: select_platform: Assertion `0' failed.
svn diff coregrind/launcher-linux.c
Index: coregrind/launcher-linux.c
===================================================================
--- coregrind/launcher-linux.c (revision 10398)
+++ coregrind/launcher-linux.c (working copy)
@@ -116,6 +116,8 @@
ssize_t n_bytes;
const char *platform = NULL;
+ assert(clientname);
+
if (strchr(clientname, '/') == NULL)
clientname = find_client(clientname);
@@ -126,6 +128,7 @@
n_bytes = read(fd, header, sizeof(header));
close(fd);
if (n_bytes < 2) {
+ assert(0);
return NULL;
}
@@ -151,6 +154,7 @@
header[i] = '\0';
platform = select_platform(interp);
+ assert(platform);
} else if (n_bytes >= SELFMAG && memcmp(header, ELFMAG, SELFMAG) == 0) {
@@ -186,6 +190,7 @@
}
}
+ assert(platform);
return platform;
}
|