|
From: <sv...@va...> - 2009-07-01 05:06:32
|
Author: njn
Date: 2009-07-01 06:05:38 +0100 (Wed, 01 Jul 2009)
New Revision: 10391
Log:
Add a comment.
Modified:
trunk/massif/ms_main.c
Modified: trunk/massif/ms_main.c
===================================================================
--- trunk/massif/ms_main.c 2009-07-01 04:50:41 UTC (rev 10390)
+++ trunk/massif/ms_main.c 2009-07-01 05:05:38 UTC (rev 10391)
@@ -303,6 +303,16 @@
// always anyway, because even if they're overloaded, it would be a
// prodigiously stupid overloading that caused them to not allocate
// memory.
+ //
+ // XXX: because we don't look at the first stack entry (unless it's a
+ // custom allocation) there's not much point to having all these alloc
+ // functions here -- they should never appear anywhere (I think?) other
+ // than the top stack entry. The only exceptions are those that in
+ // vg_replace_malloc.c are partly or fully implemented in terms of another
+ // alloc function: realloc (which uses malloc); valloc,
+ // malloc_zone_valloc, posix_memalign and memalign_common (which use
+ // memalign).
+ //
DO("malloc" );
DO("__builtin_new" );
DO("operator new(unsigned)" );
|