|
From: Julian S. <js...@ac...> - 2009-05-20 11:11:02
|
On Wednesday 20 May 2009, Nicholas Nethercote wrote: > On Wed, May 20, 2009 at 6:22 PM, Julian Seward <js...@ac...> wrote: > > Independently of your commit .. does this work reliably? It looks > > distinctly un-thread-safe to me :-) > > > > if (init_done) > > return; > > init_done = 1; > > // actually do said initialisation > > Probably not, but Valgrind is single-threaded and I expect there are a > lot of other un-thread-safe things like this...? But this is a bit different .. it runs on the VCPU, not the real one, hence is not as a whole protected by the standard BigLock scheme. iiuc .. Anyway, more an idle observation than anything else. J |