|
From: Julian S. <js...@ac...> - 2009-05-07 08:54:46
|
> > It looks to me that leak-resolution=high will be a better default as it > > will not confuse users. If a user really needs to combine various stack > > traces in one stack trace, then resolution low or medium can then be > > given. > > I agree with this. The rationale in the docs is: > > <para>For hardcore leak debugging, you probably want to use > <option>--leak-resolution=high</option> together with > <option>--num-callers=40</option> or some such large number. Note > however that this can give an overwhelming amount of information, > which is why the defaults give less information.</para> > > but I can see it would be confusing, especially since it is *different > to the way other reports are merged*. I don't have a particularly strong opinion; if you want to change the default to high, then fine. The reason I set it the way it is is because of a feeling that it's better to present a small amount of info to the user and then say "I can show you more details if you want", then to flood the user with lots of different stack traces from the start. But perhaps a bad call. > If a user gets lots of leak reports with --leak-resolution=high, then > that's because the program has lots of leaks which will need to be > fixed! Pretending otherwise doesn't make their lives easier. Julian? Well, regardless of the setting of this, we always print the totals for blocks and bytes leaked (in various ways). So it's not like we're pretending the program is less leaky than it really is. J |