Re: [Valgrind-developers] [patch] re-enable VPATH build.

[Ashley P. <as...@pi...>]

On Fri, 2009-03-27 at 08:03 -0500, Nicholas Nethercote wrote:
> On Tue, Mar 17, 2009 at 6:26 AM, Ashley Pittman <as...@pi...> wrote:
> >
> > Julian et al.
> >
> > I've been looking at Valgrind again recently and have noticed the VPATH
> > build is broken again, this patch fixes it so configure/make/make
> > install works, there are still problems with the regtests however.
> >
> > I'll admit it's not particularly tidy so if there are other ways to
> > achieve the same result they may be prefrable, one way might be to
> > rename the supp files supp.in and add them to AC_OUTPUT in configure.in
> >
> > The change of name to default.supp.new and renaming the file is to make
> > the build consistent, if the file is created but the cat fails causing
> > make to abort and then the user calls make again no attempt is made to
> > re-generate the file without this change.
> 
> Looks like there's a typo:  at one point it says default.supp.net,
> which I guess should be default.supp.new.

There was, I thought I'd regenerated that diff after I made that change
and before I sent it but perhaps not.

> This keeps breaking because none of the developers (AFAIK) use VPATH
> builds and we don't test them... perhaps we should.

I almost always use it as it allows me to test the same tree with
different configure options, it keeps source code separate from compiled
code which makes it clear which if any files need adding to version
control.

If one of the test scripts could be migrated to use VPATH then that
would probably help, this patch isn't a complete fix however,
configure/make/make install all work with it but there are further
problems remaining with IIRC make regtest.  I can take a look at them if
you want me to.

Ashley,