[Valgrind-developers] valgrind: r9429 - branches/DARWIN/none/tests

[<sv...@va...>]

Author: njn
Date: 2009-03-16 04:26:12 +0000 (Mon, 16 Mar 2009)
New Revision: 9429

Log:
Make map_unaligned work on Darwin.  Also give it a sensible
indentation+brace style.



Modified:
   branches/DARWIN/none/tests/map_unaligned.c
   branches/DARWIN/none/tests/map_unaligned.stderr.exp


Modified: branches/DARWIN/none/tests/map_unaligned.c
===================================================================
--- branches/DARWIN/none/tests/map_unaligned.c	2009-03-16 03:46:48 UTC (rev 9428)
+++ branches/DARWIN/none/tests/map_unaligned.c	2009-03-16 04:26:12 UTC (rev 9429)
@@ -2,50 +2,41 @@
 #include <stdlib.h>
 #include <sys/mman.h>
 
-#if !defined(MAP_ANONYMOUS)
-#define MAP_ANONYMOUS 0
+#if defined(__APPLE__)
+#  define MAP_ANONYMOUS MAP_ANON
 #endif
 
 int main(int argc, char **argv)
 {
-  void *p1;
-  void *p2;
+   void *p1;
+   void *p2;
 
-  if ( ( p1 = mmap( 0, 4096, PROT_READ, MAP_PRIVATE | MAP_ANONYMOUS, -1, 0 ) ) == MAP_FAILED )
-    {
-      perror( "mmap" );
+   if ( ( p1 = mmap( 0, 4096, PROT_READ, MAP_PRIVATE | MAP_ANONYMOUS, -1, 0 ) ) == MAP_FAILED )
+   {
+      perror( "aligned mmap failed" );
       exit( 1 );
-    }
+   }
 
-  if ( munmap( p1, 4096 ) != 0 )
-    {
-      perror( "munmap" );
+   if ( munmap( p1, 4096 ) != 0 )
+   {
+      perror( "aligned munmap failed" );
       exit( 1 );
-    }
+   }
 
-  if ( ( p2 = mmap( p1 + 1, 4096, PROT_READ, MAP_PRIVATE | MAP_ANONYMOUS, -1, 0 ) ) == MAP_FAILED )
-    {
-      perror( "mmap" );
+   // This fails because MAP_FIXED is specified and p1+1 isn't page-aligned.
+   // (On Linux, just non-page-alignment is enough for failure, but on Darwin
+   // MAP_FIXED has to also be specified.)
+   if ( ( p2 = mmap( p1 + 1, 4096, PROT_READ, MAP_PRIVATE | MAP_ANONYMOUS | MAP_FIXED, -1, 0 ) ) == MAP_FAILED )
+   {
+      perror( "unaligned mmap failed" );
       exit( 1 );
-    }
+   }
 
-  if ( munmap( p2, 4096 ) != 0 )
-    {
-      perror( "munmap" );
+   if ( munmap( p2, 4096 ) != 0 )
+   {
+      perror( "unaligned munmap failed" );
       exit( 1 );
-    }
+   }
 
-  if ( ( p2 = mmap( p1 + 1, 4096, PROT_READ, MAP_PRIVATE | MAP_ANONYMOUS | MAP_FIXED, -1, 0 ) ) == MAP_FAILED )
-    {
-      perror( "mmap" );
-      exit( 1 );
-    }
-
-  if ( munmap( p2, 4096 ) != 0 )
-    {
-      perror( "munmap" );
-      exit( 1 );
-    }
-
-  exit( 0 );
+   exit( 0 );
 }

Modified: branches/DARWIN/none/tests/map_unaligned.stderr.exp
===================================================================
--- branches/DARWIN/none/tests/map_unaligned.stderr.exp	2009-03-16 03:46:48 UTC (rev 9428)
+++ branches/DARWIN/none/tests/map_unaligned.stderr.exp	2009-03-16 04:26:12 UTC (rev 9429)
@@ -1,3 +1,3 @@
 
-mmap: Invalid argument
+unaligned mmap failed: Invalid argument