Menu
▾
▴
[Valgrind-developers] valgrind: r9236 - in branches/DARWIN/coregrind: . m_aspacemgr m_coredump m_scheduler m_sigframe m_syswrap
|
From: <sv...@va...> - 2009-02-23 04:29:42
|
Author: njn
Date: 2009-02-23 04:29:37 +0000 (Mon, 23 Feb 2009)
New Revision: 9236
Log:
Comment out all the #warning lines to make compilation less noisy. They're
still easy to find, as they all have both "DDD" and "#warning" in the
comment.
Modified:
branches/DARWIN/coregrind/m_aspacemgr/aspacemgr-linux.c
branches/DARWIN/coregrind/m_coredump/coredump-amd64-darwin.c
branches/DARWIN/coregrind/m_coredump/coredump-x86-darwin.c
branches/DARWIN/coregrind/m_libcproc.c
branches/DARWIN/coregrind/m_main.c
branches/DARWIN/coregrind/m_redir.c
branches/DARWIN/coregrind/m_scheduler/scheduler.c
branches/DARWIN/coregrind/m_sigframe/sigframe-amd64-darwin.c
branches/DARWIN/coregrind/m_sigframe/sigframe-x86-darwin.c
branches/DARWIN/coregrind/m_signals.c
branches/DARWIN/coregrind/m_syswrap/syswrap-amd64-darwin.c
branches/DARWIN/coregrind/m_syswrap/syswrap-darwin.c
branches/DARWIN/coregrind/m_syswrap/syswrap-generic.c
branches/DARWIN/coregrind/m_syswrap/syswrap-main.c
branches/DARWIN/coregrind/m_syswrap/syswrap-x86-darwin.c
branches/DARWIN/coregrind/m_translate.c
Modified: branches/DARWIN/coregrind/m_aspacemgr/aspacemgr-linux.c
===================================================================
--- branches/DARWIN/coregrind/m_aspacemgr/aspacemgr-linux.c 2009-02-23 04:16:56 UTC (rev 9235)
+++ branches/DARWIN/coregrind/m_aspacemgr/aspacemgr-linux.c 2009-02-23 04:29:37 UTC (rev 9236)
@@ -2206,7 +2206,7 @@
/* We have been advised that the mapping is allowable at the
specified address. So hand it off to the kernel, and propagate
any resulting failure immediately. */
-#warning GrP fixme MAP_FIXED can clobber memory!
+ // DDD: #warning GrP fixme MAP_FIXED can clobber memory!
sres = VG_(am_do_mmap_NO_NOTIFY)(
start, length, prot,
VKI_MAP_FIXED|VKI_MAP_PRIVATE,
@@ -2275,7 +2275,7 @@
/* We have been advised that the mapping is allowable at the
specified address. So hand it off to the kernel, and propagate
any resulting failure immediately. */
-#warning GrP fixme MAP_FIXED can clobber memory!
+ // DDD: #warning GrP fixme MAP_FIXED can clobber memory!
sres = VG_(am_do_mmap_NO_NOTIFY)(
start, length, prot,
VKI_MAP_FIXED|VKI_MAP_PRIVATE|VKI_MAP_ANONYMOUS,
@@ -2333,7 +2333,7 @@
/* We have been advised that the mapping is allowable at the
advised address. So hand it off to the kernel, and propagate
any resulting failure immediately. */
-#warning GrP fixme MAP_FIXED can clobber memory!
+ // DDD: #warning GrP fixme MAP_FIXED can clobber memory!
sres = VG_(am_do_mmap_NO_NOTIFY)(
advised, length, prot,
VKI_MAP_FIXED|VKI_MAP_PRIVATE|VKI_MAP_ANONYMOUS,
@@ -2793,7 +2793,7 @@
return False;
/* Extend the kernel's mapping. */
-#warning GrP fixme MAP_FIXED can clobber memory!
+ // DDD: #warning GrP fixme MAP_FIXED can clobber memory!
sres = VG_(am_do_mmap_NO_NOTIFY)(
nsegments[segR].start, delta,
prot,
@@ -2829,7 +2829,7 @@
return False;
/* Extend the kernel's mapping. */
-#warning GrP fixme MAP_FIXED can clobber memory!
+ // DDD: #warning GrP fixme MAP_FIXED can clobber memory!
sres = VG_(am_do_mmap_NO_NOTIFY)(
nsegments[segA].start-delta, delta,
prot,
Modified: branches/DARWIN/coregrind/m_coredump/coredump-amd64-darwin.c
===================================================================
--- branches/DARWIN/coregrind/m_coredump/coredump-amd64-darwin.c 2009-02-23 04:16:56 UTC (rev 9235)
+++ branches/DARWIN/coregrind/m_coredump/coredump-amd64-darwin.c 2009-02-23 04:29:37 UTC (rev 9236)
@@ -35,5 +35,5 @@
void VG_(make_coredump)(ThreadId tid, const vki_siginfo_t *si, UInt max_size)
{
-#warning GrP fixme coredump
+ // DDD: #warning GrP fixme coredump
}
Modified: branches/DARWIN/coregrind/m_coredump/coredump-x86-darwin.c
===================================================================
--- branches/DARWIN/coregrind/m_coredump/coredump-x86-darwin.c 2009-02-23 04:16:56 UTC (rev 9235)
+++ branches/DARWIN/coregrind/m_coredump/coredump-x86-darwin.c 2009-02-23 04:29:37 UTC (rev 9236)
@@ -35,5 +35,5 @@
void VG_(make_coredump)(ThreadId tid, const vki_siginfo_t *si, UInt max_size)
{
-#warning GrP fixme coredump
+ // DDD: #warning GrP fixme coredump
}
Modified: branches/DARWIN/coregrind/m_libcproc.c
===================================================================
--- branches/DARWIN/coregrind/m_libcproc.c 2009-02-23 04:16:56 UTC (rev 9235)
+++ branches/DARWIN/coregrind/m_libcproc.c 2009-02-23 04:29:37 UTC (rev 9236)
@@ -706,7 +706,7 @@
#if defined(__NR_nanosleep)
(void)VG_(do_syscall2)(__NR_nanosleep, (UWord)ts, (UWord)NULL);
#elif defined(VGO_darwin)
-# warning GrP fixme use semwait_signal for nanosleep
+ // DDD: #warning GrP fixme use semwait_signal for nanosleep
#else
# error no nanosleep implementation
#endif
Modified: branches/DARWIN/coregrind/m_main.c
===================================================================
--- branches/DARWIN/coregrind/m_main.c 2009-02-23 04:16:56 UTC (rev 9235)
+++ branches/DARWIN/coregrind/m_main.c 2009-02-23 04:29:37 UTC (rev 9236)
@@ -2043,7 +2043,7 @@
// Nb: temporarily parks the saved blocking-mask in saved_sigmask.
VG_(debugLog)(1, "main", "Initialise signal management\n");
#if defined(VGO_darwin)
-# warning GrP fixme signals
+ // DDD: #warning GrP fixme signals
#else
VG_(sigstartup_actions)();
#endif
@@ -2279,7 +2279,7 @@
/* We were killed by a fatal signal, so replicate the effect */
vg_assert(VG_(threads)[tid].os_state.fatalsig != 0);
#if defined(VGO_darwin)
-#warning GrP fixme signals
+ // DDD: #warning GrP fixme signals
#else
VG_(kill_self)(VG_(threads)[tid].os_state.fatalsig);
#endif
Modified: branches/DARWIN/coregrind/m_redir.c
===================================================================
--- branches/DARWIN/coregrind/m_redir.c 2009-02-23 04:16:56 UTC (rev 9235)
+++ branches/DARWIN/coregrind/m_redir.c 2009-02-23 04:29:37 UTC (rev 9236)
@@ -963,20 +963,20 @@
/* If we're using memcheck, use these intercepts right from
the start, otherwise dyld makes a lot of noise. */
if (0==VG_(strcmp)("Memcheck", VG_(details).name)) {
- add_hardwired_spec("dyld", "strcmp",
- (Addr)&VG_(darwin_REDIR_FOR_strcmp), NULL);
- add_hardwired_spec("dyld", "strlen",
- (Addr)&VG_(darwin_REDIR_FOR_strlen), NULL);
- add_hardwired_spec("dyld", "strcat",
- (Addr)&VG_(darwin_REDIR_FOR_strcat), NULL);
- add_hardwired_spec("dyld", "strcpy",
- (Addr)&VG_(darwin_REDIR_FOR_strcpy), NULL);
- add_hardwired_spec("dyld", "strlcat",
- (Addr)&VG_(darwin_REDIR_FOR_strlcat), NULL);
+ add_hardwired_spec("dyld", "strcmp",
+ (Addr)&VG_(darwin_REDIR_FOR_strcmp), NULL);
+ add_hardwired_spec("dyld", "strlen",
+ (Addr)&VG_(darwin_REDIR_FOR_strlen), NULL);
+ add_hardwired_spec("dyld", "strcat",
+ (Addr)&VG_(darwin_REDIR_FOR_strcat), NULL);
+ add_hardwired_spec("dyld", "strcpy",
+ (Addr)&VG_(darwin_REDIR_FOR_strcpy), NULL);
+ add_hardwired_spec("dyld", "strlcat",
+ (Addr)&VG_(darwin_REDIR_FOR_strlcat), NULL);
#if defined(VGP_amd64_darwin)
-#warning fixme rdar://6166275
- add_hardwired_spec("dyld", "arc4random",
- (Addr)&VG_(darwin_REDIR_FOR_arc4random), NULL);
+ // DDD: #warning fixme rdar://6166275
+ add_hardwired_spec("dyld", "arc4random",
+ (Addr)&VG_(darwin_REDIR_FOR_arc4random), NULL);
#endif
}
Modified: branches/DARWIN/coregrind/m_scheduler/scheduler.c
===================================================================
--- branches/DARWIN/coregrind/m_scheduler/scheduler.c 2009-02-23 04:16:56 UTC (rev 9235)
+++ branches/DARWIN/coregrind/m_scheduler/scheduler.c 2009-02-23 04:29:37 UTC (rev 9236)
@@ -430,7 +430,7 @@
VG_(threads)[tid].altstack.ss_flags = VKI_SS_DISABLE;
#if defined(VGO_darwin)
-# warning GrP fixme signals
+ // DDD: #warning GrP fixme signals
#else
{
vki_sigset_t savedmask;
@@ -879,7 +879,7 @@
if (jumped) {
block_signals(tid);
#if defined(VGO_darwin)
-# warning GrP fixme signals
+ // DDD: #warning GrP fixme signals
#else
VG_(poll_signals)(tid);
#endif
@@ -1000,7 +1000,7 @@
/* Look for any pending signals for this thread, and set them up
for delivery */
#if defined(VGO_darwin)
-# warning GrP fixme signals
+ // DDD: #warning GrP fixme signals
#else
VG_(poll_signals)(tid);
#endif
@@ -1102,7 +1102,7 @@
segment override use) */
/* jrs 2005 03 11: is this correct? */
#if defined(VGO_darwin)
-# warning GrP fixme synth signals
+ // DDD: #warning GrP fixme synth signals
VG_(core_panic)("mapfail - no synth signals on darwin");
#else
VG_(synth_fault)(tid);
@@ -1167,7 +1167,7 @@
case VEX_TRC_JMP_SIGSEGV:
#if defined(VGO_darwin)
-# warning GrP fixme synth signals
+ // DDD: #warning GrP fixme synth signals
VG_(core_panic)("sigsegv - no synth signals on darwin");
#else
VG_(synth_fault)(tid);
Modified: branches/DARWIN/coregrind/m_sigframe/sigframe-amd64-darwin.c
===================================================================
--- branches/DARWIN/coregrind/m_sigframe/sigframe-amd64-darwin.c 2009-02-23 04:16:56 UTC (rev 9235)
+++ branches/DARWIN/coregrind/m_sigframe/sigframe-amd64-darwin.c 2009-02-23 04:29:37 UTC (rev 9236)
@@ -1 +1 @@
-#warning fixme
+// DDD: #warning fixme
Modified: branches/DARWIN/coregrind/m_sigframe/sigframe-x86-darwin.c
===================================================================
--- branches/DARWIN/coregrind/m_sigframe/sigframe-x86-darwin.c 2009-02-23 04:16:56 UTC (rev 9235)
+++ branches/DARWIN/coregrind/m_sigframe/sigframe-x86-darwin.c 2009-02-23 04:29:37 UTC (rev 9236)
@@ -1 +1 @@
-#warning fixme
+// DDD: #warning fixme
Modified: branches/DARWIN/coregrind/m_signals.c
===================================================================
--- branches/DARWIN/coregrind/m_signals.c 2009-02-23 04:16:56 UTC (rev 9235)
+++ branches/DARWIN/coregrind/m_signals.c 2009-02-23 04:29:37 UTC (rev 9236)
@@ -112,7 +112,7 @@
#if defined(VGO_darwin)
-#warning GrP fixme signals
+// DDD: #warning GrP fixme signals
#else
Modified: branches/DARWIN/coregrind/m_syswrap/syswrap-amd64-darwin.c
===================================================================
--- branches/DARWIN/coregrind/m_syswrap/syswrap-amd64-darwin.c 2009-02-23 04:16:56 UTC (rev 9235)
+++ branches/DARWIN/coregrind/m_syswrap/syswrap-amd64-darwin.c 2009-02-23 04:29:37 UTC (rev 9236)
@@ -92,9 +92,9 @@
static void x86_float_state64_from_vex(x86_float_state64_t *mach,
VexGuestAMD64State *vex)
{
-#warning GrP fixme fp state
+ // DDD: #warning GrP fixme fp state
- VG_(memcpy)(&mach->__fpu_xmm0, &vex->guest_XMM0, 16 * sizeof(mach->__fpu_xmm0));
+ VG_(memcpy)(&mach->__fpu_xmm0, &vex->guest_XMM0, 16 * sizeof(mach->__fpu_xmm0));
}
@@ -134,7 +134,7 @@
vex->guest_RSI = mach->__rsi;
vex->guest_RBP = mach->__rbp;
vex->guest_RSP = mach->__rsp;
-#warning GrP fixme eflags
+ // DDD: #warning GrP fixme eflags
vex->guest_RIP = mach->__rip;
vex->guest_R8 = mach->__r8;
vex->guest_R9 = mach->__r9;
@@ -154,7 +154,7 @@
static void x86_float_state64_to_vex(const x86_float_state64_t *mach,
VexGuestAMD64State *vex)
{
-#warning GrP fixme fp state
+ // DDD: #warning GrP fixme fp state
VG_(memcpy)(&vex->guest_XMM0, &mach->__fpu_xmm0, 16 * sizeof(mach->__fpu_xmm0));
}
Modified: branches/DARWIN/coregrind/m_syswrap/syswrap-darwin.c
===================================================================
--- branches/DARWIN/coregrind/m_syswrap/syswrap-darwin.c 2009-02-23 04:16:56 UTC (rev 9235)
+++ branches/DARWIN/coregrind/m_syswrap/syswrap-darwin.c 2009-02-23 04:29:37 UTC (rev 9236)
@@ -775,7 +775,7 @@
//tst->sys_flags &= ~SfMayBlock;
break;
-#warning GrP fixme darwin-specific ioctl
+ // DDD: #warning GrP fixme darwin-specific ioctl
case VKI_FIODTYPE:
PRE_MEM_WRITE( "ioctl(FIONREAD)", ARG3, sizeof(int) );
break;
@@ -902,7 +902,7 @@
case VKI_SIOCSPGRP:
break;
-#warning GrP fixme darwin-specific ioctl
+ // DDD: #warning GrP fixme darwin-specific ioctl
case VKI_FIODTYPE:
POST_MEM_WRITE( ARG3, sizeof(int) );
break;
@@ -2116,8 +2116,8 @@
ML_(buf_and_len_pre_check) ( tid, optval_p, optlen_p,
"socketcall.getsockopt(optval)",
"socketcall.getsockopt(optlen)" );
-# warning GrP fixme darwin-specific sockopts
}
+ // DDD: #warning GrP fixme darwin-specific sockopts
}
POST(sys_getsockopt)
@@ -2129,7 +2129,7 @@
ML_(buf_and_len_post_check) ( tid, VG_(mk_SysRes_Success)(RES),
optval_p, optlen_p,
"socketcall.getsockopt(optlen_out)" );
-# warning GrP fixme darwin-specific sockopts
+ // DDD: #warning GrP fixme darwin-specific sockopts
}
}
@@ -2783,7 +2783,7 @@
oldset = (vki_sigset_t*)ARG3;
#if defined(VGO_darwin)
-#warning GrP fixme signals
+ // DDD: #warning GrP fixme signals
#else
SET_STATUS_from_SysRes(
VG_(do_sys_sigprocmask) ( tid, ARG1 /*how*/, set, oldset)
@@ -2817,7 +2817,7 @@
PRE_MEM_WRITE( "sigaltstack(oss)", ARG2, sizeof(vki_stack_t) );
}
-# warning GrP fixme signals
+ // DDD: # warning GrP fixme signals
// GrP fixme leopard 9A241 setjmp dies if sigaltstack fails (ecx)
SET_STATUS_Success(0);
}
@@ -4876,7 +4876,7 @@
MACH_ARG(mach_vm_protect.size));
UInt prot = MACH_ARG(mach_vm_protect.new_protection);
if (MACH_ARG(mach_vm_protect.set_maximum)) {
-#warning GrP fixme mprotect max
+ // DDD: #warning GrP fixme mprotect max
//VG_(mprotect_max_range)(start, end-start, prot);
} else {
ML_(notify_aspacem_and_tool_of_mprotect)(start, end-start, prot);
Modified: branches/DARWIN/coregrind/m_syswrap/syswrap-generic.c
===================================================================
--- branches/DARWIN/coregrind/m_syswrap/syswrap-generic.c 2009-02-23 04:16:56 UTC (rev 9235)
+++ branches/DARWIN/coregrind/m_syswrap/syswrap-generic.c 2009-02-23 04:29:37 UTC (rev 9236)
@@ -774,7 +774,7 @@
void VG_(init_preopened_fds)(void)
{
#if defined(VGO_darwin)
-# warning GrP fixme preopened fds
+ // DDD: #warning GrP fixme preopened fds
#else
Int ret;
struct vki_dirent d;
@@ -2454,7 +2454,7 @@
/* Let other thread(s) run */
VG_(vg_yield)();
#if defined(VGO_darwin)
-# warning GrP fixme signals
+ // DDD: #warning GrP fixme signals
#else
VG_(poll_signals)(self);
#endif
@@ -2629,7 +2629,7 @@
VG_(setrlimit)(VKI_RLIMIT_DATA, &VG_(client_rlimit_data));
#if defined(VGO_darwin)
-# warning GrP fixme exec signals busted
+ // DDD: #warning GrP fixme exec signals busted
#else
/*
Set the signal state up for exec.
@@ -4056,7 +4056,7 @@
}
#if defined(VGO_darwin)
-# warning GrP fixme signals
+ // DDD: #warning GrP fixme signals
#else
SET_STATUS_from_SysRes(
VG_(do_sys_sigaltstack) (tid, (vki_stack_t*)ARG1,
Modified: branches/DARWIN/coregrind/m_syswrap/syswrap-main.c
===================================================================
--- branches/DARWIN/coregrind/m_syswrap/syswrap-main.c 2009-02-23 04:16:56 UTC (rev 9235)
+++ branches/DARWIN/coregrind/m_syswrap/syswrap-main.c 2009-02-23 04:29:37 UTC (rev 9236)
@@ -1704,7 +1704,7 @@
might have been created, and will have set SfPollAfter to
request a poll for them once the syscall is done. */
#if defined(VGO_darwin)
-# warning GrP fixme signals
+ // DDD: # warning GrP fixme signals
#else
if (sci->flags & SfPollAfter)
VG_(poll_signals)(tid);
@@ -1849,7 +1849,7 @@
int $0x80 == CD 80
int $0x80 == CD 81
*/
-#warning GrP fixme sysenter, int $0x81, int $0x82
+ // DDD: #warning GrP fixme sysenter, int $0x81, int $0x82
{
UChar *p = (UChar *)arch->vex.guest_EIP;
@@ -1862,7 +1862,7 @@
}
#elif defined(VGP_amd64_darwin)
-#warning GrP fixme amd64 restart unimplemented
+ // DDD: #warning GrP fixme amd64 restart unimplemented
vg_assert(0);
#else
Modified: branches/DARWIN/coregrind/m_syswrap/syswrap-x86-darwin.c
===================================================================
--- branches/DARWIN/coregrind/m_syswrap/syswrap-x86-darwin.c 2009-02-23 04:16:56 UTC (rev 9235)
+++ branches/DARWIN/coregrind/m_syswrap/syswrap-x86-darwin.c 2009-02-23 04:29:37 UTC (rev 9236)
@@ -85,9 +85,9 @@
static void x86_float_state32_from_vex(i386_float_state_t *mach,
VexGuestX86State *vex)
{
-#warning GrP fixme fp state
+ // DDD: #warning GrP fixme fp state
- VG_(memcpy)(&mach->__fpu_xmm0, &vex->guest_XMM0, 8 * sizeof(mach->__fpu_xmm0));
+ VG_(memcpy)(&mach->__fpu_xmm0, &vex->guest_XMM0, 8 * sizeof(mach->__fpu_xmm0));
}
@@ -128,7 +128,7 @@
vex->guest_EBP = mach->__ebp;
vex->guest_ESP = mach->__esp;
vex->guest_SS = mach->__ss;
-#warning GrP fixme eflags
+ // DDD: #warning GrP fixme eflags
vex->guest_EIP = mach->__eip;
vex->guest_CS = mach->__cs;
vex->guest_DS = mach->__ds;
@@ -140,7 +140,7 @@
static void x86_float_state32_to_vex(const i386_float_state_t *mach,
VexGuestX86State *vex)
{
-#warning GrP fixme fp state
+ // DDD: #warning GrP fixme fp state
VG_(memcpy)(&vex->guest_XMM0, &mach->__fpu_xmm0, 8 * sizeof(mach->__fpu_xmm0));
}
Modified: branches/DARWIN/coregrind/m_translate.c
===================================================================
--- branches/DARWIN/coregrind/m_translate.c 2009-02-23 04:16:56 UTC (rev 9235)
+++ branches/DARWIN/coregrind/m_translate.c 2009-02-23 04:29:37 UTC (rev 9236)
@@ -1361,7 +1361,7 @@
/* U R busted, sonny. Place your hands on your head and step
away from the orig_addr. */
#if defined(VGO_darwin)
-#warning GrP fixme synth signals
+ // DDD: #warning GrP fixme synth signals
{
VG_(message)(Vg_UserMsg, "ERROR\n");
VG_(message)(Vg_UserMsg, "Thread %d jumped to bad address %#llx",
|
