|
From: <sv...@va...> - 2009-01-16 06:53:13
|
Author: njn
Date: 2009-01-16 06:53:04 +0000 (Fri, 16 Jan 2009)
New Revision: 8962
Log:
Update comments about Helgrind and DRD tests that don't build on Darwin.
Modified:
branches/DARWIN/drd/tests/Makefile.am
branches/DARWIN/helgrind/tests/Makefile.am
Modified: branches/DARWIN/drd/tests/Makefile.am
===================================================================
--- branches/DARWIN/drd/tests/Makefile.am 2009-01-16 05:06:35 UTC (rev 8961)
+++ branches/DARWIN/drd/tests/Makefile.am 2009-01-16 06:53:04 UTC (rev 8962)
@@ -264,10 +264,10 @@
check_PROGRAMS += qt4_mutex qt4_rwlock qt4_semaphore
endif
-# DDD: not sure if these ones should work on Darwin or not... if not, should
-# be moved into x86-linux/.
-# (Darwin pthreads doesn't seem to support barriers.)
-# [barriers and spinlocks are optional in pthreads]
+# DDD: all of these (except sigalrm and trylock) use barriers and/or
+# spinlocks, which are optional in pthreads and Darwin doesn't support.
+# Could do a configure-time test like the one done for Qt above.
+# (Not sure about sigalrm and trylock, whether they should work or not.)
if ! VGO_DARWIN
check_PROGRAMS += \
bar_bad \
Modified: branches/DARWIN/helgrind/tests/Makefile.am
===================================================================
--- branches/DARWIN/helgrind/tests/Makefile.am 2009-01-16 05:06:35 UTC (rev 8961)
+++ branches/DARWIN/helgrind/tests/Makefile.am 2009-01-16 06:53:04 UTC (rev 8962)
@@ -154,10 +154,9 @@
tc23_bogus_condwait \
tc24_nonzero_sem
-# DDD: not sure if these ones should work on Darwin or not... if not, should
-# be moved into x86-linux/.
-# (Darwin pthreads doesn't seem to support barriers.)
-# [barriers and spinlocks are optional in pthreads]
+# DDD: all of these use barriers and/or spinlocks, which are optional in
+# pthreads and Darwin doesn't support. Could do a configure-time test like
+# the one done for Qt above.
if ! VGO_DARWIN
check_PROGRAMS += \
bar_bad \
|