|
From: Bart V. A. <bar...@gm...> - 2009-01-08 13:37:32
|
On Wed, Jan 7, 2009 at 7:23 AM, Nicholas Nethercote
<n.n...@gm...> wrote:
> I just committed some improvements to the 'nightly' script. All the
> .diff files are now concatenated into a single file (files longer than
> 100 lines are truncated). The name of this file is passed to the
> conf/<tag>.sendmail script as a 3rd argument. Installations of the
> script don't need to use that 3rd arg, but the obvious thing to do is
> to attach the file containing the diffs. AFAICT the easiest way to do
> this is to install 'mutt' and use the -a option to add an attachment.
>
> I didn't zip the diffs file, because I think it may usually be small
> enough to not bother, and not zipping it makes it easier to read.
> I could have put the diffs in a tar file instead. If anyone has a
> strong preference for that I could do so.
>
> Also, since the diffs file is currently not zipped, it would also be
> easy to append the diffs to the body of the email and get rid of the
> 3rd argument. Opinions are welcome on that as well.
Thanks Nicholas for these changes.
Hello Tom,
Have you already had the time to change your nightly/conf/*.sendmail
files such that the diff files get included in the e-mail sent after
the nightly build ? Changing "/usr/bin/mail ... <$2" into something
like "{ cat "$2"; echo; echo "Diffs:"; echo; cat "$3"; } |
/usr/bin/mail ..." should be sufficient.
Bart.
|