|
From: Greg P. <gp...@ap...> - 2009-01-07 21:28:51
|
On Jan 7, 2009, at 1:24 PM, Greg Parker wrote: > On Jan 7, 2009, at 12:23 PM, Peter Wemm wrote: >> It breaks on FreeBSD's sed too. Build works, but install (and a few >> other things) fail (including ldscript generation). I'd changed >> configure.in locally to find sed and use $(SED) in the scripts so >> that >> one could specify a path to gnu sed on systems where it isn't the >> default one. > > Outside the tests, I see three ugly-looking uses of sed. > > 1. Makefile.am: generating the valt_load_address ldscript. Darwin > doesn't use ldscripts and doesn't support valt_load_address, so we > don't care. > 2. Makefile.install.am: installing tools with hyphens in the name. > exp- > omega ends up in the right place, so I guess this works fine. > 3. Makefile.install.am: installing libcoregrind.a and libvex.a. For > some reason noinst_LIBRARIES is empty here, so I don't know whether > the expressions work or not. (For whom would libcoregrind.a and > libvex.a be installed anyway?) Never mind, noinst_LIBRARIES is set and #3 is failing, but it's a syntax error in `expr` not a sed problem. -- Greg Parker gp...@ap... Runtime Wrangler |