|
From: J. B. <jb...@gm...> - 2008-12-03 01:11:35
|
Thanks! As I wrote, this is not meant for inclusion (yet -- among others, I need to clean it up), just a heads up where the current status is. I'll make sure to fix the issues you pointed out. -Johan On Tue, Dec 2, 2008 at 4:58 PM, Robert Walsh <rj...@du...> wrote: > Minor feedback on the patch: > > * In cg-arm.c, you might want to update the copyright, since you > created this file. > * In cg-arm.c, the warning message says "PPC32" instead of "ARM". > * d3basics.c has what looks like a debugging VG_(printf) left in > there. Also in m_machine.c, sigframe-arm-linux.c, etc. > * readdwarf.c comments out a debug message. Why? > * m_main.c forward-declares raise and __aeabi_unwind_cpp_pr0, and > then immediately implements them. Any reason why? > > I haven't looked beyond sigframe-arm-linux.c yet, so I may have more > when I get a moment to take a look. > > General comment: > > * Indenting is 3 spaces, no tabs. > > Note: I haven't tried this patch myself, as I don't have a linux-arm > box to try with. These comments are just from code inspection. > > Regards, > Robert. > |