|
From: Robert W. <rj...@du...> - 2008-12-03 00:58:27
|
Minor feedback on the patch: * In cg-arm.c, you might want to update the copyright, since you created this file. * In cg-arm.c, the warning message says "PPC32" instead of "ARM". * d3basics.c has what looks like a debugging VG_(printf) left in there. Also in m_machine.c, sigframe-arm-linux.c, etc. * readdwarf.c comments out a debug message. Why? * m_main.c forward-declares raise and __aeabi_unwind_cpp_pr0, and then immediately implements them. Any reason why? I haven't looked beyond sigframe-arm-linux.c yet, so I may have more when I get a moment to take a look. General comment: * Indenting is 3 spaces, no tabs. Note: I haven't tried this patch myself, as I don't have a linux-arm box to try with. These comments are just from code inspection. Regards, Robert. |