Re: [Valgrind-developers] valgrind: r8311 - branches/FORMATCHECK/coregrind

[Dirk M. <dm...@gm...>]

On Tuesday 01 July 2008, Julian Seward wrote:

> Er, no, I don't think it's thread safe, or at least it would be difficult
> to construct an argument that it would.  It would be much better to have
> the caller allocate the buffer.

Uglifies the code.. a bit..

> What is the reason for needing VG_(ToXML) anyway?  I thought the
> XML output stuff worked OK as it is.

VG_(printf) uses "%t" as a "xml-escaped %s" attribute. This does not if gcc 
format checking is enabled, as %t is a nonstandard extension, which it doesn't 
understand. I've asked you some time ago wether it would be okay to either map 
it to "%s" and use a ToXml function for the argument, or to use a completely 
different (non printf-like) function for xml output. I guess the latter makes 
more sense, as line formatting (printf) doesn't really make sense with xml 
output, the stream output can be abstracted into something else. 

Greetings,
Dirk