|
From: Rich C. <Ric...@me...> - 2008-06-05 19:26:48
|
I'm supposing this patch will fix bug 162753.
http://bugs.kde.org/show_bug.cgi?id=162753
Ashley Pittman <api...@co...> wrote:
>
> On Wed, 2008-06-04 at 08:47 +0200, Julian Seward wrote:
> > On Monday 02 June 2008 12:10, Ashley Pittman wrote:
> > > On Mon, 2008-06-02 at 11:53 +0200, Julian Seward wrote:
> > > > I have put a release candidate for 3.3.1 at
> > > >
> > > > http://www.valgrind.org/downloads/valgrind-3.3.1.RC1.tar.bz2
> > > > (md5 = 7b8325af2156c679d825d15eb38a0bd4)
> > > >
> > > > Please download and try it on platforms that are important to you, and
> > > > let me know of any critical breakage. If no critical problems are
> > > > reported, I plan to make make the final 3.3.1 release on Wednesday 4
> > > > June.
> > >
> > > Could you apply this patch to re-enable the log file qualifier in the
> > > xml output.
> >
> > Applied to the trunk. Ta. I'd prefer not to change the visible
> > behaviour of the stable branch at this point.
>
> So this will in the 3.3.1 release? That's all I care about, my users
> are waiting on the malinfo stuff so will be on that anyway.
>
> > > Also did the VPATH build issue get fixed?
> >
> > No .. there's a patch floating around somewhere, isn't there, that
> > you sent before? Not sure where though. Any ideas?
>
> I've got this but I don't think it's a full patch, I seem to remember I
> also had to remove VG_(start_debugger) from pub_core_debugger.h and add
> it somewhere else, at this point I decided that the entire header file
> probably needed re-naming as pub_tool_debugger.h hence my comment about
> not being able to make a patch that encompasses the changes. You'll
> need to do a svn move and lots of build build changes to do this
> properly so perhaps it's better to leave that header file empty and
> create a new one with the declaration in it.
>
> Let me know if you want me to look at this deeper, I'm off to work now
> but will be able to take a proper look this evening if you require.
>
> Would it be prudent to adjust one of the nightly builds to use VPATH?
> It's not the first time it's broken and it often takes a while to spot
> that's anythings wrong.
>
> Ashley,
>
--
Rich Coe ric...@me...
Virtual Principle Engineer General Electric Healthcare Technologies
Global Software Platforms, Computer Technology Team
|