|
From: Julian S. <js...@ac...> - 2008-05-02 18:35:52
|
> Shouldn't the code below fill in sps[0] and fps[0] ? See also
> coregrind/m_stacktrace.c, starting at line 101.
>
> /* Assertion broken before main() is reached in pthreaded programs; the
> * offending stack traces only have one item. --njn, 2002-aug-16 */
> /* vg_assert(fp_min <= fp_max);*/
> if (fp_min + 512 >= fp_max) {
> /* If the stack limits look bogus, don't poke around ... but
> don't bomb out either. */
> ips[0] = ip;
> return 1;
> }
Er, yes it probably should, for consistency. I can't think what
the consequences would be if it didn't; presumably returning junk
to the caller. Which isn't good. Well spotted.
J
|