[Valgrind-valkyrie-dev] valkyrie 1.20 crash/bugfix

[Donna R. <do...@va...>]

Am posting this to the list so is visible to all.
The relevant bit of code referred to is in /core/memcheck_object.cpp
and the crash is on line "if ( !m_vgreader->parseContinue()) {"

void Memcheck::readVgLog()
{
  // vkPrint("Memcheck::readVgLog()");
  vk_assert( view !- 0 );
  vk_assert( m_vgreader != 0 );
  vk_assert( m_vgproc != 0 );

  qApp-> processEvents();

  /* Try reading some more data */
  if ( !m_vgreader->parseContinue()) {
    /* Parsing failed: stop m_vgproc, if running */
    if (m_vgproc->isRunning())
      m_vgproc->stop(); /* signal -> rpocessDone() */
  }
}


--------------------------------------------------

valkyrie 1.20 crash/bugfix
 Date: Yesterday 10:23:23
 From: "Gert Steenssens" <gst...@gm...>
 To: su...@op...
 
Hi,

I've been using your great GUI valkyrie for checking some memory leaks with
valgrind,
and have noticed a strange crash when the program I was profiling exited.

valkyrie is parsing valgrind output and all of a sudden crashes.
The exact location of the crash you can see on the image attached when I ran
it with KDBG.
Turns out it's due to a NULL pointer deref...

To resolve it I just added a check to see if  'vgreader' was not a NULL
pointer before it is referenced.
which resolved my problem though I haven't searched for the exact reason of
the crash...

Just thought you might like to know... ;)

and thanks for valkyrie!

greetings,
Gert