|
From: Ashley P. <api...@co...> - 2008-03-03 16:18:44
|
On Mon, 2008-03-03 at 17:01 +0100, Julian Seward wrote: > On Monday 03 March 2008 16:51, Ashley Pittman wrote: > > I'm trying a VPATH build of valgrind and have found that omega doesn't > > build when using VPATH, it appears omega is the only tool to try and > > include pub_core_options.h > > Euh, that's a bug. By definition tools are only allowed to see > include/pub_tool_*.h and not coregrind/anythingatall.h. > > You could probably fix this by changing the include to be > pub_tool_include.h, and then moving any required definitions from > the core_ to tool_ include files. > > But before you do that, have a look at > http://bugs.kde.org/show_bug.cgi?id=155913 > since that fixes vpath compilation, i believe. That looks like it should fix it however as you say gives tools full access to coregrind/*.h The attached patch should work although the VG_(start_debugger) function is the only prototype in pub_core_debugger.h so the whole file should probably be moved to include/pub_tool_debugger.h and the Makefiles updated accordingly. It's only the two prototypes omega needs to compile. Ashley, |