|
From: Nicholas N. <nj...@cs...> - 2007-11-23 22:38:09
|
On Fri, 23 Nov 2007, Josef Weidendorfer wrote:
> VG_(expand_file_name) looks almost good to me.
>
> In callgrind, I allow to set an absolute output name with eg. "--base=/tmp/clgout".
> If the format starts with a slash, we could skip prefixing the output with
> the base_dir.
Done.
> Very minor points:
> playing a little bit with %q, I got misleading errors.
>
> weidendo@linux:~> valgrind --log-file=foo%q ls
> ==17529== --log-file: expected 'p' or 'q' or '%' after '%'
> valgrind: Bad option '--log-file=foo%q'; aborting.
> valgrind: Use --help for more information.
>
> weidendo@linux:~> valgrind --log-file=foo%q{x}%q{y} ls
> ==17625== --log-file: environment variable x is not set
> valgrind: Bad option '--log-file=foo%q{x'; aborting.
> valgrind: Use --help for more information.
Fixed and fixed.
Thanks for the feedback!
N
|