|
From: Josef W. <Jos...@gm...> - 2007-09-17 12:29:00
|
On Monday 17 September 2007, sv...@va... wrote:
> Author: njn
> Date: 2007-09-17 01:41:07 +0100 (Mon, 17 Sep 2007)
> New Revision: 6839
>
> Log:
> Add directory-reading of debug info to cachegrind.
Hi Nick,
thanks for doing this. Exactly the same change works perfectly also
in callgrind.
When testing it, source annotation worked out of the box
with KCachegrind, but also with the callgrind_annotate script.
Therefore I wondered about your change...
> Modified: trunk/cachegrind/cg_annotate.in
> ===================================================================
> --- trunk/cachegrind/cg_annotate.in 2007-09-17 00:33:52 UTC (rev 6838)
> +++ trunk/cachegrind/cg_annotate.in 2007-09-17 00:41:07 UTC (rev 6839)
> @@ -747,7 +747,9 @@
>
> my $opened_file = "";
> my $full_file_name = "";
> - foreach my $include_dir (@include_dirs) {
> + # We first try it with the empty include_dir, in case the filename has
> + # the full path.
> + foreach my $include_dir ("", @include_dirs) {
This seems to not be needed, as @include_dir is initialized as
...
my @include_dirs = ("");
...
Ie. the emty entry is already there.
Josef
|