Re: [Valgrind-developers] valgrind: r6742 - in branches/CGTUNE: cachegrind callgrind coregrind helgrind include lackey massif memcheck none

[Julian S. <js...@ac...>]

> >    VG_(basic_tool_funcs)          (cg_post_clo_init,
> >                                    cg_instrument,
> > +                                   NULL,
> >                                    cg_fini);
>
> I don't like having an extra argument to this function which is almost
> always NULL, this function is for registering functions that are mandatory.
>
> Better would be a new 'need', since that's the mechanism for registering
> optional callbacks.  

Yes - I entirely agree.  Really this was a quick hack to see if there 
was any mileage in the idea.

> Maybe VG_(needs_extra_IR_pass), with the relevant 
> callback named "extra_IR_pass" ?

How about needs_final_IR_tidy?  extra_IR_pass doesn't give any hint of 
what the pass is for.

J