|
From: Nicholas N. <nj...@cs...> - 2007-05-16 21:59:03
|
On Wed, 16 May 2007 sv...@va... wrote: > Log: > Another optimisation: allow tools to provide a final_tidy function > which they can use to mess with the final post-tree-built IR before it > is handed off to instruction selection. > > In memcheck, use this to remove redundant calls to > MC_(helperc_value_check0_fail) et al. Gives a 6% reduction in code > size for Memcheck on x86 and a smaller (3% ?) speedup. nice! > VG_(basic_tool_funcs) (cg_post_clo_init, > cg_instrument, > + NULL, > cg_fini); I don't like having an extra argument to this function which is almost always NULL, this function is for registering functions that are mandatory. Better would be a new 'need', since that's the mechanism for registering optional callbacks. Maybe VG_(needs_extra_IR_pass), with the relevant callback named "extra_IR_pass" ? Nick |