|
From: <sv...@va...> - 2007-04-19 23:35:52
|
Author: njn
Date: 2007-04-20 00:35:42 +0100 (Fri, 20 Apr 2007)
New Revision: 6707
Log:
It's generally a good idea to set call-by-reference arguments, especially
when the function comments says that they always are set.
Modified:
trunk/coregrind/m_debuginfo/debuginfo.c
Modified: trunk/coregrind/m_debuginfo/debuginfo.c
===================================================================
--- trunk/coregrind/m_debuginfo/debuginfo.c 2007-04-19 09:47:32 UTC (rev 6706)
+++ trunk/coregrind/m_debuginfo/debuginfo.c 2007-04-19 23:35:42 UTC (rev 6707)
@@ -740,8 +740,11 @@
(dirname != NULL && dirname_available != NULL) );
search_all_loctabs ( a, &si, &locno );
- if (si == NULL)
+ if (si == NULL) {
+ if (dirname_available) *dirname_available = False;
return False;
+ }
+
VG_(strncpy_safely)(filename, si->loctab[locno].filename, n_filename);
*lineno = si->loctab[locno].lineno;
|