[Valgrind-developers] valgrind: r6500 - branches/ORIGIN_TRACKING/memcheck

[<sv...@va...>]

Author: njn
Date: 2007-01-10 12:06:01 +0000 (Wed, 10 Jan 2007)
New Revision: 6500

Log:
Some notes and stuff.

Modified:
   branches/ORIGIN_TRACKING/memcheck/mc_main.c


Modified: branches/ORIGIN_TRACKING/memcheck/mc_main.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- branches/ORIGIN_TRACKING/memcheck/mc_main.c	2007-01-10 04:57:27 UTC (=
rev 6499)
+++ branches/ORIGIN_TRACKING/memcheck/mc_main.c	2007-01-10 12:06:01 UTC (=
rev 6500)
@@ -33,9 +33,11 @@
 // XXX: origin-tracking todo:
 // - try recording ExeContexts for stack allocation sites, alter the
 //   new_mem_stack* events to allow the origin_low32 to be passed in.
-// - do timings, to work out how much slow-down it causes.  Specialise
-//   the helperc functions some if possible.  Work out if checking
-//   clo_undef_origins frequently slows things down much.
+// - do timings:
+//   - to work out how much slow-down it causes. =20
+//   - Specialise the helperc functions some if possible.
+//   - Work out if checking clo_undef_origins frequently slows things do=
wn
+//     much. [seemingly not]
=20
 #include "pub_tool_basics.h"
 #include "pub_tool_aspacemgr.h"
@@ -1815,10 +1817,6 @@
 /*--- Stack pointer adjustment                             ---*/
 /*------------------------------------------------------------*/
=20
-// XXX: should try recording code addresses for stack allocations, to gi=
ve
-// a 1-deep stack trace.  Hmm, but difficult because code addresses are
-// word-sized.  We'd need an ip_low32-to-ip table...
-
 static void VG_REGPARM(1) mc_new_mem_stack_4(Addr new_SP)
 {
    PROF_EVENT(110, "new_mem_stack_4");
@@ -2998,7 +2996,7 @@
=20
 static void mc_pp_origins ( ExeContext* origins[], Int n_origins )
 {
-   // XXX: in origin-yes, get two origins for the 64-bit stack case --
+   // XXX: in origin-yes, we get two origins for the 64-bit stack case -=
-
    // should remove dup'd origins from the list.
   =20
    // XXX: is this XML-isation good enough?