|
From: Julian S. <js...@ac...> - 2006-11-23 16:39:26
|
In principle I agree with Josef, but I have a different suggestion for implementation. The core module m_machine exists precisely to give a convenient place to record/discover various aspects of the CPU we are running on. And so I think the cache detection stuff should all be moved in there. J On Thursday 23 November 2006 16:10, Josef Weidendorfer wrote: > On Thursday 23 November 2006 14:04, sv...@va... wrote: > > Author: weidendo > > Date: 2006-11-23 13:04:30 +0000 (Thu, 23 Nov 2006) > > New Revision: 6369 > > > > Log: > > Cachegrind/Callgrind: Fix cache parameter detection > > I think we really should get rid of the total duplication > of code in cg-amd64.c and cg-x86.c. They are currently > more or less exactly the same. > > Whatever new additions are needed, they will be needed for > both files, as any 64bit x86 processor can also run in > 32bit mode. > > How to do it best? > I suggest moving the code into a new cg-x86-amd64.c and > include it both in cg-amd64.c and cg-x86.c. > > Josef > > ------------------------------------------------------------------------- > Take Surveys. Earn Cash. Influence the Future of IT > Join SourceForge.net's Techsay panel and you'll get the chance to share > your opinions on IT & business topics through brief surveys - and earn cash > http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV > _______________________________________________ > Valgrind-developers mailing list > Val...@li... > https://lists.sourceforge.net/lists/listinfo/valgrind-developers |